-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a functional Debian Package for Capstone v5 #2569
Conversation
00673b2
to
3af3d27
Compare
Based on libcapstone-dev for version 4.0.1, I see this. Based on this, I need Other fixes:
libcapstone4.deb
libcapstone-dev.deb v4.0.2 (note, this does require libcapstone4)
Current version
|
188d707
to
27bab19
Compare
Showing proof of new changes to new Debian file @Rot127
capstone.pc can correctly get the Project Version from CMakeLists.txt, which can now be dynamically updated via CI/CD, and can handle pre-release versions by parsing out major.minor.patch Yes, I am aware there is a blank /usr/lib/pkgconfig library, but this is a very minor issue, as I think based on this draft, I have a pretty functional package working now. And I created a release with the package I'm going to now attempt testing this with PANDA shortly with this PR |
7a62be2
to
b156163
Compare
0a02a08
to
888b695
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks better now!
Please add your copyright to all files in SPDX format:
// SPDX-FileCopyrightText: 2024 AndrewQuijano <your-mail>
// SPDX-License-Identifier: <License you like this under. Default is BSD-3>
888b695
to
67e4c7e
Compare
@Rot127 I just made the changes, actually, could you merge into v5 and create version '5.0.4'? I can confirm, when I install the Debian package, and use |
67e4c7e
to
a612ccb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, lgtm. Just those three little things.
could you merge into v5 and create version '5.0.4'?
@kabeor has to merge and do the release. I don't have the privileges to do so.
a612ccb
to
40f3c60
Compare
Finally able to test Debian Package dynamically with PANDA, but please create the new release, I'd rather PANDA pull the Debian package from capstone than my fork. |
@kabeor The PANDA integration test completed correctly, please merge both PRs for Debian Package on v5/v6 and create 5.0.4 release, I'm hoping to get my PR into PANDA done before the Christmas break |
@kabeor and this pair of PRs please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Your checklist for this pull request
Detailed description
This is based on continuing work, I hope to create at least a functional Debian Package for Capstonev5 used within PANDA. I updated the control file to be much more detailed to align for eventual future publishing to Debian Repositories.
Fixes completed:
Since this is a Debian binary package control file, I only need to follow this guidance
https://www.debian.org/doc/debian-policy/ch-controlfields.html#debian-binary-package-control-files-debian-control
...
Test plan
...
Closing issues
Would just be progress on packaging goal.
References on past work:
#2543
#2521
I think based on the quality of the work, this should close #2537. The next work would be just to send this to Debian, but it seems like it has everything Debian could want, based on what I see from the current old packages.
...