feat: [CHK-3139] Expose http metrics #563
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This service is the core of eCommerce, the performance is very important. |
pietro-tota
reviewed
Aug 28, 2024
Comment on lines
+3
to
+8
| application: true # reports startup time, useful for future comparison | ||
| http.server.requests: true # reports http request counts | ||
| resilience4j.circuitbreaker: true # reports circuit breaker status | ||
| jvm.memory: true # reports heap status | ||
| jvm.gc: true # reports garbage collector metrics, useful to detect too long pauses | ||
| mongodb.driver: true # reports useful mongo statistics, like waiting queue |
There was a problem hiding this comment.
I would expose only requests count metrics disabling others. those can be enabled in the future as needed.
What do you think?
There was a problem hiding this comment.
Yes, I'm agree, the purpose was to get more data during testing, so now, I will disable useless metrics :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable service monitor (aka prometheus scraping) to collect metrics from expose
/actuator/prometheusendpoint. Also enable the endpoint itself by exposing some useful information like HTTP requests count.List of Changes
serviceMonitorsection from helm chart/actuator/prometheusendpointMotivation and Context
How Has This Been Tested?
Tested on Grafana by seeing reported metrics using prometheus as data source
Screenshots (if appropriate):
Types of changes
Checklist: