[CHK-2736] feat(NPG): handle new fields from GET auth-data wallet api #475

giovanniberti · 2024-04-12T08:46:31Z

Big PR warning?

Most of the lines changed are either tests or indentation, while there are little changes to the actual business logic :)

List of Changes

handle new fields from wallet GET auth-data (in particular: last four digits for cards, masked email for PayPal)
refactor code handling payment session data

Motivation and Context

This PR is necessary to collect data needed to invoke Nodo's closePayment endpoint and fill with all the relevant data about a transaction.

How Has This Been Tested?

TODO

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.

~~Depends on #473~~
~~Depends on pagopa/pagopa-ecommerce-commons#192~~

Depends on pagopa/pagopa-infra#1925
Depends on pagopa/pagopa-wallet-service#132

dpulls · 2024-04-12T08:46:34Z

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

pom.xml

dpulls · 2024-04-15T09:00:12Z

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

pom.xml

dpulls · 2024-04-18T08:46:48Z

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

dpulls · 2024-04-18T08:47:04Z

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

pietro-tota · 2024-05-03T13:06:19Z

pom.xml

@@ -346,7 +346,7 @@
                            <goal>generate</goal>
                        </goals>
                        <configuration>
-                            <inputSpec>https://raw.githubusercontent.com/pagopa/pagopa-infra/main/src/domains/wallet-app/api/payment-wallet-for-ecommerce/v1/_openapi.json.tpl</inputSpec>
+                            <inputSpec>https://raw.githubusercontent.com/pagopa/pagopa-infra/CHK-2736-wallet-auth-data/src/domains/wallet-app/api/payment-wallet-for-ecommerce/v1/_openapi.json.tpl</inputSpec>


Suggested change

<inputSpec>https://raw.githubusercontent.com/pagopa/pagopa-infra/CHK-2736-wallet-auth-data/src/domains/wallet-app/api/payment-wallet-for-ecommerce/v1/_openapi.json.tpl</inputSpec>

<inputSpec>https://raw.githubusercontent.com/pagopa/pagopa-infra/main/src/domains/wallet-app/api/payment-wallet-for-ecommerce/v1/_openapi.json.tpl</inputSpec>

TODO: to be replaced after dependent pr merge

dpulls · 2024-05-03T13:20:32Z

🎉 All dependencies have been resolved !

dpulls · 2024-05-03T13:23:10Z

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

dpulls · 2024-05-03T13:24:02Z

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

dpulls · 2024-05-03T13:24:39Z

⚠️ Dpulls not installed on repository pagopa/pagopa-ecommerce-transactions-service. Checkout our quickstart for how to install.

pietro-tota · 2024-05-03T13:49:59Z

src/main/java/it/pagopa/transactions/services/v1/TransactionsService.java

+                                                    case PaymentSessionData.CardSessionData cardSessionData ->
+                                                            cardSessionData.cardBin().value();
+                                                    case PaymentSessionData.PgsCardSessionData cardSessionData -> cardSessionData.cardBin().value();
+                                                    case PaymentSessionData.WalletCardSessionData cardSessionData ->


WalletCardSessionData, CardSessionData and PgsCardSessionData could implement a common interface (let say CardData) with methods: cardBin(), brand() and other common fields so that were needed those switch cases can be collapsed to an if statement against the fact that PaymentSessionData is instance of the CardData interface.
What do you think?

sonarqubecloud · 2024-05-08T16:13:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

… digits

…ization

github-actions · 2024-07-15T15:37:30Z

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

sonarqubecloud · 2024-07-15T15:45:58Z

Quality Gate passed

Issues
91 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions bot added the size/small label Apr 12, 2024

giovanniberti changed the base branch from main to CHK-2675-npg-mybank-validationServiceId April 12, 2024 08:46

giovanniberti added patch chart-patch labels Apr 12, 2024

giovanniberti commented Apr 12, 2024

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

giovanniberti force-pushed the CHK-2736-wallet-auth-data branch from 38ded35 to 86b034b Compare April 12, 2024 15:05

giovanniberti changed the title ~~[CHK-2736] feat(NPG): save POST notification validationServiceId field into events~~ [CHK-2736] feat(NPG): handle new fields from GET auth-data wallet api Apr 13, 2024

giovanniberti commented Apr 15, 2024

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

giovanniberti marked this pull request as ready for review April 15, 2024 09:04

giovanniberti requested a review from a team as a code owner April 15, 2024 09:04

Base automatically changed from CHK-2675-npg-mybank-validationServiceId to main April 18, 2024 08:30

giovanniberti force-pushed the CHK-2736-wallet-auth-data branch from 407cd4f to af5780a Compare April 18, 2024 08:40

github-actions bot added size/large and removed size/small labels Apr 18, 2024

giovanniberti force-pushed the CHK-2736-wallet-auth-data branch from af5780a to b294e94 Compare April 18, 2024 08:42

pietro-tota reviewed May 3, 2024

View reviewed changes

pietro-tota previously approved these changes May 3, 2024

View reviewed changes

giovanniberti dismissed pietro-tota’s stale review via 7e0753f May 7, 2024 14:15

giovanniberti force-pushed the CHK-2736-wallet-auth-data branch from 911ee86 to 7e0753f Compare May 7, 2024 14:15

pietro-tota previously approved these changes May 8, 2024

View reviewed changes

giovanniberti dismissed pietro-tota’s stale review via 699f780 May 8, 2024 16:06

giovanniberti force-pushed the CHK-2736-wallet-auth-data branch from 7e0753f to 699f780 Compare May 8, 2024 16:06

giovanniberti force-pushed the CHK-2736-wallet-auth-data branch from 699f780 to 664b54b Compare May 16, 2024 09:02

pietro-tota previously approved these changes May 16, 2024

View reviewed changes

giovanniberti dismissed pietro-tota’s stale review via 4ccbdcb June 27, 2024 10:53

giovanniberti force-pushed the CHK-2736-wallet-auth-data branch from 664b54b to 4ccbdcb Compare June 27, 2024 10:53

giovanniberti added 5 commits July 15, 2024 15:57

feat(wallet): handle new fields from GET auth-data wallet api

dc85115

refactor(auth): refactor payment session data

abd73b9

refactor(payment-session-data): add checks for card bin and last four…

b58350c

… digits

refactor: use BIN and CardLastFourDigits domain classes from commons

f1c3613

fix(auth-request): add session id missing case for wallet card author…

7d44711

…ization

giovanniberti force-pushed the CHK-2736-wallet-auth-data branch from 4ccbdcb to 7d44711 Compare July 15, 2024 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CHK-2736] feat(NPG): handle new fields from GET auth-data wallet api #475

[CHK-2736] feat(NPG): handle new fields from GET auth-data wallet api #475

giovanniberti commented Apr 12, 2024 •

edited

Loading

dpulls bot commented Apr 12, 2024

dpulls bot commented Apr 15, 2024

dpulls bot commented Apr 18, 2024

dpulls bot commented Apr 18, 2024

pietro-tota May 3, 2024

dpulls bot commented May 3, 2024

dpulls bot commented May 3, 2024

dpulls bot commented May 3, 2024

dpulls bot commented May 3, 2024

pietro-tota May 3, 2024 •

edited

Loading

sonarqubecloud bot commented May 8, 2024

github-actions bot commented Jul 15, 2024

sonarqubecloud bot commented Jul 15, 2024

	<inputSpec>https://raw.githubusercontent.com/pagopa/pagopa-infra/CHK-2736-wallet-auth-data/src/domains/wallet-app/api/payment-wallet-for-ecommerce/v1/_openapi.json.tpl</inputSpec>
	<inputSpec>https://raw.githubusercontent.com/pagopa/pagopa-infra/main/src/domains/wallet-app/api/payment-wallet-for-ecommerce/v1/_openapi.json.tpl</inputSpec>

[CHK-2736] feat(NPG): handle new fields from GET auth-data wallet api #475

Are you sure you want to change the base?

[CHK-2736] feat(NPG): handle new fields from GET auth-data wallet api #475

Conversation

giovanniberti commented Apr 12, 2024 • edited Loading

Big PR warning?

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

dpulls bot commented Apr 12, 2024

dpulls bot commented Apr 15, 2024

dpulls bot commented Apr 18, 2024

dpulls bot commented Apr 18, 2024

pietro-tota May 3, 2024

Choose a reason for hiding this comment

dpulls bot commented May 3, 2024

dpulls bot commented May 3, 2024

dpulls bot commented May 3, 2024

dpulls bot commented May 3, 2024

pietro-tota May 3, 2024 • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented May 8, 2024

Quality Gate passed

github-actions bot commented Jul 15, 2024

sonarqubecloud bot commented Jul 15, 2024

Quality Gate passed

giovanniberti commented Apr 12, 2024 •

edited

Loading

pietro-tota May 3, 2024 •

edited

Loading