-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(retry): disable retry for blocking exceptions #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work 👏
src/test/java/it/pagopa/transactions/services/v1/CircuitBreakerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/pagopa/transactions/services/v1/CircuitBreakerTest.java
Show resolved
Hide resolved
src/test/java/it/pagopa/transactions/services/v1/CircuitBreakerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/pagopa/transactions/services/v1/CircuitBreakerTest.java
Outdated
Show resolved
Hide resolved
…rTest.java Co-authored-by: Giovanni Berti <[email protected]>
giovanniberti
previously approved these changes
Nov 30, 2023
src/test/java/it/pagopa/transactions/services/v2/CircuitBreakerTest.java
Outdated
Show resolved
Hide resolved
…rTest.java Co-authored-by: Giovanni Berti <[email protected]>
# Conflicts: # pom.xml
giovanniberti
approved these changes
Dec 1, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Configured
ignoreExceptions
forresilience4j
retry and circuit breaker in order to ignore retry for all of those exception that are blocking (such as TransactionNotFoundException) and for which a retry cannot make the original request succeed.Motivation and Context
The original configuration ignores only exception related to Nodo response errors (NodoErrorException) so other errors are not ignored activating circuit breaker and retry logic.
This causes circuit breaker being opened and retry being performed also for request related errors (such as transaction not being found, or authorization request amount mismatch)
How Has This Been Tested?
Junit tests (checking for retry count and circuit breaker status) + local test using eCommerce local
Screenshots (if appropriate):
Types of changes
Checklist: