-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Challenge] Add Trick room challenge #4343
base: beta
Are you sure you want to change the base?
[Challenge] Add Trick room challenge #4343
Conversation
Co-authored-by: NightKev <[email protected]>
Co-authored-by: NightKev <[email protected]>
Co-authored-by: NightKev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
I'd have to do play-testing but don't have time right now
It would be lost the next time the item atlas is updated otherwise.
I will test it and update screenshots and video! thanks for the review!! 👍 |
Yes, which probably isn't bad, but also you could still set it up to prevent that if you wanted. |
The challenge code should decide which tags are added, not the phase code. I'd elaborate a bit but reviewing on mobile is a pain. Feel free to ask on discord though, I can elaborate. |
yeah, updated! |
Dont forget to move the English locales to another PR in this new repo and delete them from this PR! |
@KimJeongSun You can delete the locales from your PR, I added all of them here: |
What are the changes the user will see?
can enjoy trick room challenge! let's Snorlax!
Why am I making these changes?
@Tempo-anon 's suggestion! thanks for the idea!
What are the changes from a developer perspective?
Screenshots/Videos
( overrided starting level=100 and starting wave = 21 and 201 for clear screenshot )
Screen.Recording.2024-09-21.at.12.14.01.AM.mp4
Screen.Recording.2024-09-21.at.1.45.03.PM.2.mp4
How to test the changes?
Checklist
beta
as my base branch[ ] Have I considered writing automated tests for the issue?npm run test
)