Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Challenge] Add Trick room challenge #4343

Open
wants to merge 29 commits into
base: beta
Choose a base branch
from

Conversation

KimJeongSun
Copy link
Collaborator

@KimJeongSun KimJeongSun commented Sep 20, 2024

What are the changes the user will see?

can enjoy trick room challenge! let's Snorlax!

Why am I making these changes?

@Tempo-anon 's suggestion! thanks for the idea!

What are the changes from a developer perspective?

  • add trick room challenge
  • add TrickRoomTag when start encounter in this challenge
  • add achievement for it (update achievement logic to disable other challenges' achievement like inverse battle challenge)
  • (cancel) invert starting speed IV - we will handle this with change IVs menu in starting select UI later

Screenshots/Videos

( overrided starting level=100 and starting wave = 21 and 201 for clear screenshot )

Screen.Recording.2024-09-21.at.12.14.01.AM.mp4
Screenshot 2024-09-21 at 1 42 56 AM Screenshot 2024-09-21 at 1 43 21 AM
  • battle test (200 wave)
Screen.Recording.2024-09-21.at.1.45.03.PM.2.mp4
  • run history test screenshot
Screenshot 2024-09-21 at 1 50 57 PM

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • [ ] Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@KimJeongSun KimJeongSun added the Challenges Challenge mode/s related label Sep 20, 2024
@KimJeongSun KimJeongSun changed the base branch from main to beta September 20, 2024 15:49
@KimJeongSun KimJeongSun marked this pull request as ready for review September 20, 2024 16:48
@KimJeongSun KimJeongSun requested review from a team as code owners September 20, 2024 16:48
src/data/challenge.ts Show resolved Hide resolved
src/data/challenge.ts Outdated Show resolved Hide resolved
src/data/challenge.ts Outdated Show resolved Hide resolved
@KimJeongSun KimJeongSun marked this pull request as draft September 20, 2024 17:12
src/data/challenge.ts Outdated Show resolved Hide resolved
src/data/challenge.ts Show resolved Hide resolved
src/data/challenge.ts Outdated Show resolved Hide resolved
src/data/challenge.ts Outdated Show resolved Hide resolved
src/phases/turn-start-phase.ts Outdated Show resolved Hide resolved
src/system/achv.ts Outdated Show resolved Hide resolved
@KimJeongSun KimJeongSun marked this pull request as ready for review September 20, 2024 17:22
@KimJeongSun KimJeongSun requested a review from flx-sta September 20, 2024 18:07
Copy link
Contributor

@flx-sta flx-sta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
I'd have to do play-testing but don't have time right now

Madmadness65 and others added 2 commits September 20, 2024 21:17
It would be lost the next time the item atlas is updated otherwise.
@KimJeongSun
Copy link
Collaborator Author

Code looks good. I'd have to do play-testing but don't have time right now

I will test it and update screenshots and video! thanks for the review!! 👍

@KimJeongSun KimJeongSun requested a review from DayKev September 21, 2024 05:26
@KimJeongSun KimJeongSun requested a review from DayKev September 21, 2024 09:53
DayKev
DayKev previously approved these changes Sep 21, 2024
@Xavion3
Copy link
Contributor

Xavion3 commented Sep 22, 2024

Yes, which probably isn't bad, but also you could still set it up to prevent that if you wanted.

src/data/challenge.ts Outdated Show resolved Hide resolved
@KimJeongSun KimJeongSun requested a review from Xavion3 September 27, 2024 18:26
@Xavion3
Copy link
Contributor

Xavion3 commented Sep 30, 2024

The challenge code should decide which tags are added, not the phase code. I'd elaborate a bit but reviewing on mobile is a pain. Feel free to ask on discord though, I can elaborate.

@KimJeongSun
Copy link
Collaborator Author

The challenge code should decide which tags are added, not the phase code. I'd elaborate a bit but reviewing on mobile is a pain. Feel free to ask on discord though, I can elaborate.

yeah, updated!

@Adri1
Copy link
Contributor

Adri1 commented Oct 5, 2024

Dont forget to move the English locales to another PR in this new repo and delete them from this PR!

@Adri1
Copy link
Contributor

Adri1 commented Oct 15, 2024

@KimJeongSun You can delete the locales from your PR, I added all of them here:
pagefaultgames/pokerogue-locales#32

@KimJeongSun KimJeongSun requested review from DayKev and Xavion3 October 27, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Challenges Challenge mode/s related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants