Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Trick Room challenge translations #4519

Closed

Conversation

Adri1
Copy link
Contributor

@Adri1 Adri1 commented Sep 30, 2024

What are the changes the user will see?

None, translation of pending PR #4343

Why am I making these changes?

To have it translated

What are the changes from a developer perspective?

None

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?

@Adri1 Adri1 added the Localization Provides or updates translation efforts label Sep 30, 2024
@Adri1 Adri1 requested review from a team as code owners September 30, 2024 11:31
src/locales/ja/achv.json Outdated Show resolved Hide resolved
src/locales/ja/challenges.json Outdated Show resolved Hide resolved
Copy link
Contributor

@40chyan 40chyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zh_cn

src/locales/zh_CN/achv.json Outdated Show resolved Hide resolved
Copy link
Contributor

@DanStevensonx DanStevensonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated to Spanish

src/locales/es/challenges.json Outdated Show resolved Hide resolved
src/locales/es/achv.json Outdated Show resolved Hide resolved
src/locales/ko/achv.json Outdated Show resolved Hide resolved
src/locales/ko/challenges.json Outdated Show resolved Hide resolved
Chapybara-jp
Chapybara-jp previously approved these changes Oct 2, 2024
NicusPulcis
NicusPulcis previously approved these changes Oct 3, 2024
Copy link
Contributor

@NicusPulcis NicusPulcis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

italian localized

src/locales/it/achv.json Outdated Show resolved Hide resolved
src/locales/it/challenges.json Outdated Show resolved Hide resolved
src/locales/ko/challenges.json Outdated Show resolved Hide resolved
@innerthunder
Copy link
Contributor

@Adri1 is this still needed with the locale migration?

@Adri1
Copy link
Contributor Author

Adri1 commented Oct 11, 2024

@Adri1 is this still needed with the locale migration?

No, but as long as the PR tied to this one don't show any new sign of activity nor the dev of it decided to added the English keys to the locale repo, I keep it alive as it contains pending translations.
I'll delete it only after I can copy-paste it in Pontoon

@Adri1 Adri1 closed this Oct 15, 2024
@Adri1 Adri1 deleted the trick-room-challenge-translations branch October 16, 2024 18:36
@Adri1 Adri1 restored the trick-room-challenge-translations branch October 16, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants