-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tox 4 for release testing #333
Conversation
I wonder if this ultimately needs to be the PR that breaks release testing into separate PyPI and Conda tests: tox and conda don't play together very nicely without the tox-conda package which is not compatible with tox 4. Specifically, our tox setup needs access to interpreters for multiple python versions, and conda only wants to give you one of those at a time. We may need to switch conda environments at the workflow level to test those builds. |
037e060
to
b45ba56
Compare
This is looking good, only Conda tests are failing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are mostly due to me I suspect, but rather than interfere with your work on the branch
5a94e58
to
7d12f65
Compare
Have you given this tox a test with a manual run or workflow trigger? |
Have just run it and looks good: https://github.com/pace-neutrons/Euphonic/actions/runs/12356249062 |
Task failed successfully? |
I would like to split the PyPI and Conda tests next so that something goes green when PyPI is good 😆 . I don't think it matters much if that is done before or after #332 is merged. |
Splitting it into two steps in the workflow with |
Separate workflow is better because these are different releases, typically built and tested on different days. It may even be best not to use tox for the conda one. |
Not backwards compatible with prior releases, requires #324 release.
Cannot test without #324 release.