Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tox 4 for release testing #333

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Use tox 4 for release testing #333

merged 6 commits into from
Dec 16, 2024

Conversation

oerc0122
Copy link
Collaborator

Not backwards compatible with prior releases, requires #324 release.

Cannot test without #324 release.

@oerc0122 oerc0122 added blocked This issue cannot be worked on because it is blocked by another issue no_ci Will stop CI from running on an open PR labels Nov 26, 2024
@oerc0122 oerc0122 self-assigned this Nov 26, 2024
@ajjackson ajjackson mentioned this pull request Dec 5, 2024
@ajjackson ajjackson modified the milestones: v1.4.1, v1.4.2 Dec 5, 2024
@ajjackson
Copy link
Collaborator

I wonder if this ultimately needs to be the PR that breaks release testing into separate PyPI and Conda tests: tox and conda don't play together very nicely without the tox-conda package which is not compatible with tox 4. Specifically, our tox setup needs access to interpreters for multiple python versions, and conda only wants to give you one of those at a time. We may need to switch conda environments at the workflow level to test those builds.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Test Results

    22 files   -     1      22 suites   - 1   56m 35s ⏱️ - 1h 17m 58s
 1 066 tests ±    0   1 060 ✅ ±    0    6 💤 ± 0  0 ❌ ±0 
23 320 runs  +7 976  23 188 ✅ +7 927  132 💤 +49  0 ❌ ±0 

Results for commit 7d12f65. ± Comparison against base commit 4412373.

♻️ This comment has been updated with latest results.

@ajjackson ajjackson changed the title [BLOCKED][WIP] Use tox 4 for release testing [WIP] Use tox 4 for release testing Dec 16, 2024
@ajjackson
Copy link
Collaborator

This is looking good, only Conda tests are failing now.

Copy link
Collaborator Author

@oerc0122 oerc0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are mostly due to me I suspect, but rather than interfere with your work on the branch

build_utils/release_tox.ini Outdated Show resolved Hide resolved
build_utils/release_tox.ini Outdated Show resolved Hide resolved
build_utils/release_tox.ini Outdated Show resolved Hide resolved
@oerc0122
Copy link
Collaborator Author

Have you given this tox a test with a manual run or workflow trigger?

@ajjackson
Copy link
Collaborator

Have just run it and looks good: https://github.com/pace-neutrons/Euphonic/actions/runs/12356249062

@ajjackson ajjackson changed the title [WIP] Use tox 4 for release testing Use tox 4 for release testing Dec 16, 2024
@ajjackson ajjackson marked this pull request as ready for review December 16, 2024 16:14
@oerc0122
Copy link
Collaborator Author

Have just run it and looks good: https://github.com/pace-neutrons/Euphonic/actions/runs/12356249062

  conda-py310: FAIL code 1 (0.65 seconds)
  conda-py311: FAIL code 1 (0.64 seconds)
  conda-py312: FAIL code 1 (0.65 seconds)

Task failed successfully?

@ajjackson
Copy link
Collaborator

ajjackson commented Dec 16, 2024

I would like to split the PyPI and Conda tests next so that something goes green when PyPI is good 😆 .

I don't think it matters much if that is done before or after #332 is merged.

@oerc0122
Copy link
Collaborator Author

I would like to split the PyPI and Conda tests next so that something goes green when PyPI is good 😆 .

I don't think it matters much if that is done before or after #332 is merged.

Splitting it into two steps in the workflow with tox -e ENV should be easy.

@ajjackson
Copy link
Collaborator

ajjackson commented Dec 16, 2024

Separate workflow is better because these are different releases, typically built and tested on different days. It may even be best not to use tox for the conda one.

@ajjackson ajjackson merged commit 5c5ee4f into 330-tox-4 Dec 16, 2024
15 of 19 checks passed
@oerc0122 oerc0122 mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue cannot be worked on because it is blocked by another issue no_ci Will stop CI from running on an open PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants