-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch/sled metadata to ddm/mgd related timeseries #6955
Draft
zeeshanlakhani
wants to merge
8
commits into
zl/tfportd-oximeter
Choose a base branch
from
zl/mgd-ddm-meta
base: zl/tfportd-oximeter
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bd0ce73
Update SMF properties for Dendrite to include sled identifiers
zeeshanlakhani 7d27632
schema updates: new switch identifiers & formatting
zeeshanlakhani 915f7e4
update dendrite
zeeshanlakhani 86b02d6
expunge old time series and switch slot type
zeeshanlakhani bfffdf5
toml consistency
zeeshanlakhani ab1f377
expunge dendrite ts and fix ts name
zeeshanlakhani 6a92864
Add tfport-data-link timeseries schema and SMF config adds.
zeeshanlakhani 24c967f
Add switch/sled metadata to ddm/mgd related timeseries
zeeshanlakhani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
switch_data_link:bytes_sent | ||
switch_data_link:bytes_received | ||
switch_data_link:errors_sent | ||
switch_data_link:errors_received | ||
switch_data_link:receive_crc_error_drops | ||
switch_data_link:receive_buffer_full_drops | ||
switch_data_link:packets_sent | ||
switch_data_link:packets_received | ||
switch_data_link:link_up | ||
switch_data_link:link_enabled | ||
switch_data_link:link_fsm | ||
switch_data_link:pcs_bad_sync_headers | ||
switch_data_link:pcs_errored_blocks | ||
switch_data_link:pcs_block_lock_loss | ||
switch_data_link:pcs_high_ber | ||
switch_data_link:pcs_valid_errors | ||
switch_data_link:pcs_invalid_errors | ||
switch_data_link:pcs_unknown_errors | ||
switch_data_link:pcs_sync_loss | ||
switch_data_link:fec_high_symbol_errors | ||
switch_data_link:fec_sync_aligned | ||
switch_data_link:fec_corrected_blocks | ||
switch_data_link:fec_uncorrected_blocks | ||
switch_data_link:fec_symbol_errors | ||
dendrite:sample_collection_duration |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
bgp_session:active_connections_accepted | ||
bgp_session:connection_retries | ||
bgp_session:hold_timer_expirations | ||
bgp_session:idle_hold_timer_expirations | ||
bgp_session:keepalive_send_failures | ||
bgp_session:keepalives_received | ||
bgp_session:keepalives_sent | ||
bgp_session:notification_send_failures | ||
bgp_session:open_handle_failures | ||
bgp_session:open_send_failures | ||
bgp_session:opens_received | ||
bgp_session:opens_sent | ||
bgp_session:passive_connections_accepted | ||
bgp_session:prefixes_advertised | ||
bgp_session:prefixes_imported | ||
bgp_session:transition_to_active | ||
bgp_session:transition_to_connect | ||
bgp_session:transition_to_established | ||
bgp_session:transition_to_idle | ||
bgp_session:transition_to_open_confirm | ||
bgp_session:transition_to_open_sent | ||
bgp_session:transition_to_session_setup | ||
bgp_session:unexpected_keepalive_messages | ||
bgp_session:unexpected_open_messages | ||
bgp_session:unexpected_update_messages | ||
bgp_session:update_nexthop_missing | ||
bgp_session:update_send_failures | ||
bgp_session:updates_received | ||
bgp_session:updates_sent | ||
bfd_session:control_packet_send_failures | ||
bfd_session:control_packets_sent | ||
bfd_session:control_packets_received | ||
bfd_session:message_receive_error | ||
bfd_session:timeout_expired | ||
bfd_session:transition_to_down | ||
bfd_session:transition_to_init | ||
bfd_session:transition_to_up | ||
mg_lower:routes_blocked_by_link_state | ||
switch_rib:active_routes | ||
ddm_session:advertisements_received | ||
ddm_session:advertisements_sent | ||
ddm_session:imported_tunnel_endpoints | ||
ddm_session:imported_underlay_prefixes | ||
ddm_session:peer_address_changes | ||
ddm_session:peer_expirations | ||
ddm_session:peer_sessions_established | ||
ddm_session:solicitations_received | ||
ddm_session:solicitations_sent | ||
ddm_session:update_send_fail | ||
ddm_session:updates_received | ||
ddm_session:updates_sent | ||
ddm_router:originated_tunnel_endpoints | ||
ddm_router:originated_underlay_prefixes |
25 changes: 25 additions & 0 deletions
25
oximeter/db/schema/single-node/13/timeseries-to-delete.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
switch_data_link:bytes_sent | ||
switch_data_link:bytes_received | ||
switch_data_link:errors_sent | ||
switch_data_link:errors_received | ||
switch_data_link:receive_crc_error_drops | ||
switch_data_link:receive_buffer_full_drops | ||
switch_data_link:packets_sent | ||
switch_data_link:packets_received | ||
switch_data_link:link_up | ||
switch_data_link:link_enabled | ||
switch_data_link:link_fsm | ||
switch_data_link:pcs_bad_sync_headers | ||
switch_data_link:pcs_errored_blocks | ||
switch_data_link:pcs_block_lock_loss | ||
switch_data_link:pcs_high_ber | ||
switch_data_link:pcs_valid_errors | ||
switch_data_link:pcs_invalid_errors | ||
switch_data_link:pcs_unknown_errors | ||
switch_data_link:pcs_sync_loss | ||
switch_data_link:fec_high_symbol_errors | ||
switch_data_link:fec_sync_aligned | ||
switch_data_link:fec_corrected_blocks | ||
switch_data_link:fec_uncorrected_blocks | ||
switch_data_link:fec_symbol_errors | ||
dendrite:sample_collection_duration |
39 changes: 39 additions & 0 deletions
39
oximeter/db/schema/single-node/14/timeseries-to-delete.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
bgp_session:active_connections_accepted | ||
bgp_session:connection_retries | ||
bgp_session:hold_timer_expirations | ||
bgp_session:idle_hold_timer_expirations | ||
bgp_session:keepalive_send_failures | ||
bgp_session:keepalives_received | ||
bgp_session:keepalives_sent | ||
bgp_session:notification_send_failures | ||
bgp_session:open_handle_failures | ||
bgp_session:open_send_failures | ||
bgp_session:opens_received | ||
bgp_session:opens_sent | ||
bgp_session:passive_connections_accepted | ||
bgp_session:prefixes_advertised | ||
bgp_session:prefixes_imported | ||
bgp_session:transition_to_active | ||
bgp_session:transition_to_connect | ||
bgp_session:transition_to_established | ||
bgp_session:transition_to_idle | ||
bgp_session:transition_to_open_confirm | ||
bgp_session:transition_to_open_sent | ||
bgp_session:transition_to_session_setup | ||
bgp_session:unexpected_keepalive_messages | ||
bgp_session:unexpected_open_messages | ||
bgp_session:unexpected_update_messages | ||
bgp_session:update_nexthop_missing | ||
bgp_session:update_send_failures | ||
bgp_session:updates_received | ||
bgp_session:updates_sent | ||
bfd_session:control_packet_send_failures | ||
bfd_session:control_packets_sent | ||
bfd_session:control_packets_received | ||
bfd_session:message_receive_error | ||
bfd_session:timeout_expired | ||
bfd_session:transition_to_down | ||
bfd_session:transition_to_init | ||
bfd_session:transition_to_up | ||
mg_lower:routes_blocked_by_link_state | ||
switch_rib:active_routes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnaecker, there's a question about which switch and sled fields we really need. Is it just
switch_id
(what Ry recommended)? Do we include anything beyondsled_id
for sled stuff? I laid everything out as we get all the data (either via smf or dpd-client), but it's easy to restrict this. Thoughts?