Add switch/sled metadata to ddm/mgd related timeseries #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes: - package-manifest update to match the properties added to dpd - removal of client call to get sled idenifier information (no longer used) - switch_slot added to oximeter schemas for dendrite/switch-data-link
Related to oxidecomputer/dendrite#1033. New timeseries (from sled-data-link) as we've added switch information in the metadata.
zeeshanlakhani
added a commit
to oxidecomputer/maghemite
that referenced
this pull request
Oct 30, 2024
zeeshanlakhani
force-pushed
the
zl/mgd-ddm-meta
branch
from
aed11e2 to
24c967f
Compare
zeeshanlakhani
commented
Oct 30, 2024
| @@ -5,7 +5,7 @@ name = "bfd_session" | |||
| description = "A Bidirectional Forwarding Protocol (BFD) session" | |||
| authz_scope = "fleet" | |||
| versions = [ | |||
| { version = 1, fields = [ "hostname", "rack_id", "sled_id", "peer" ] }, | |||
| { version = 1, fields = [ "hostname", "peer", "rack_id", "sled_id", "sled_model", "sled_revision", "sled_serial", "switch_id", "switch_fab", "switch_lot", "switch_wafer", "switch_wafer_loc_x", "switch_wafer_loc_y", "switch_model", "switch_revision", "switch_serial", "switch_slot" ] }, | |||
There was a problem hiding this comment.
@bnaecker, there's a question about which switch and sled fields we really need. Is it just switch_id (what Ry recommended)? Do we include anything beyond sled_id for sled stuff? I laid everything out as we get all the data (either via smf or dpd-client), but it's easy to restrict this. Thoughts?
zeeshanlakhani
force-pushed
the
zl/tfportd-oximeter
branch
2 times, most recently
from
4c9a71d to
819eded
Compare
Nieuwejaar
reviewed
Nov 1, 2024
There was a problem hiding this comment.
This looks pretty straightforward. It might be worth having @bnaecker sanity check the oximeter stuff. It looks fine to me, but I haven't worked with any of the schema stuff before.
|
|
||
| for address in addresses { | ||
| tfport_config = tfport_config.add_property( | ||
| "address", |
There was a problem hiding this comment.
Yep, will do for these and tfport in the sep PRs.
|
@Nieuwejaar I'll leave this in draft and wait on the dpd/tfport changes to go in first before updating. |
zeeshanlakhani
force-pushed
the
zl/tfportd-oximeter
branch
3 times, most recently
from
59a6171 to
e05245b
Compare
zeeshanlakhani
force-pushed
the
zl/tfportd-oximeter
branch
from
2673909 to
50dd4b8
Compare
zeeshanlakhani
force-pushed
the
zl/tfportd-oximeter
branch
from
50dd4b8 to
177ccc6
Compare
zeeshanlakhani
force-pushed
the
zl/tfportd-oximeter
branch
from
177ccc6 to
4113601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.