Read / write timeseries schema with the native client #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
force-pushed
the
manipulate-schema-with-native-client
branch
9 times, most recently
from
b95c5bf to
fa3b05f
Compare
- Add methods for converting an array of objects into a data block, or deserializing an array out of one. - Use new to/from block methods to read and write timeseries schema in the native format - Add native `Connection` method for inserting data in a block. - Implement deserialization of the `TableColumns` server message type, which is sent to client when it tries to insert data, and is used to check that the block to be inserted matches the structure of the table into which the insertion is directed. - Add a build script, which reads the `db-init.sql` file to extract the enum data type definitions into constants. This is used in the serialization of timeseries schema rows into a block. - Add better handling of HTTP / native addresses in Nexus setup - Closes #6942
bnaecker
force-pushed
the
manipulate-schema-with-native-client
branch
from
fa3b05f to
6c8b927
Compare
|
Friendly ping on this @andrewjstone and @jgallagher :) |
andrewjstone
approved these changes
Nov 6, 2024
| //! As is helpfully noted in the ClickHouse sources at | ||
| //! <https://github.com/ClickHouse/ClickHouse/blob/424ecb86e0f04a9422dd01f9216cdbe3c0e314e2/src/Storages/ColumnsDescription.cpp#L132>, | ||
| //! | ||
| //! > NOTE: Serialization format is insane. |
| @@ -221,12 +248,109 @@ impl Connection { | |||
| self.writer.send(ClientPacket::Query(query)).await?; | |||
| probes::packet__sent!(|| "Query"); | |||
| self.outstanding_query = true; | |||
|
|
|||
| // If we have data to send, wait for the server to send an empty block | |||
There was a problem hiding this comment.
This is nice and easy to understand! Thanks!
- Add comment to new build.rs - Add test for parsing bad data types with `nom` - Add message and context to `InvalidPacket` err variant
bnaecker
added a commit
that referenced
this pull request
Nov 8, 2024
- Most of the work to use the native client during schema updates was already done in #6943. One annoyingly small exception is the code that lists the tables in the database, which we use for expunging old timeseries schema from all the relevant tables. This switches to using the native client to list tables too. - Fixes #7015
bnaecker
added a commit
that referenced
this pull request
Nov 8, 2024
- Most of the work to use the native client during schema updates was already done in #6943. One annoyingly small exception is the code that lists the tables in the database, which we use for expunging old timeseries schema from all the relevant tables. This switches to using the native client to list tables too. - Fixes #7015
bnaecker
added a commit
that referenced
this pull request
Nov 8, 2024
- Most of the work to use the native client during schema updates was already done in #6943. One annoyingly small exception is the code that lists the tables in the database, which we use for expunging old timeseries schema from all the relevant tables. This switches to using the native client to list tables too. - Fixes #7015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connectionmethod for inserting data in a block.TableColumnsserver message type, which is sent to client when it tries to insert data, and is used to check that the block to be inserted matches the structure of the table into which the insertion is directed.db-init.sqlfile to extract the enum data type definitions into constants. This is used in the serialization of timeseries schema rows into a block.