Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quasi-lock dependencies in omicron-common job #6692

Merged
merged 2 commits into from
Sep 26, 2024
Merged

quasi-lock dependencies in omicron-common job #6692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2148614
quasi-lock dependencies in omicron-common
iximeow Sep 27, 2024
278ca2e
explain why we do the weird thing
iximeow Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/buildomat/jobs/omicron-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,16 @@ cd /tmp
cargo new --lib test-project
cd test-project
cargo add omicron-common --path /work/oxidecomputer/omicron/common
# Bootstrap `test-project`'s dependencies from the checked-in Cargo.lock.
# This means that `test-project` builds with the same commits as the main repo
# for any dependencies referenced as `{ git = "...", ref = "<branch>" }`. If we
# do not prepopulate `Cargo.lock` like this, an update in a dependency might get
# picked up here and be incompatible with `omicron-common`, causing it to fail
# to build (see Omicron issue #6691).
#
# The extra dependencies in `omicron` will get pruned by Cargo when it
# recalculates dependencies, but any dependencies that match will stay at the
# commit/version/etc already indicated in the lockfile.
cp /work/oxidecomputer/omicron/Cargo.lock Cargo.lock
sunshowers marked this conversation as resolved.
Show resolved Hide resolved
cargo check
cargo build --release
Loading