quasi-lock dependencies in omicron-common job #6692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"fixes" #6691 by stealing the checked-in Cargo.lock when building the standalone
omicron-common
crate created for this job. this lets us keep the specific refs of git dependencies that areref="main"
and similar, which might otherwise resolve to different commits than the rest of the tree (and itsomicron-common
) can actually build with.it'd be nice to have fewer git dependencies using branch names for refs, either by using a cratesio crate or specific commit or something, but this seems to make things a bit less brittle in the mean time.
https://github.com/oxidecomputer/omicron/runs/30726055679 passes here while failing to build on main 🎉