back out "Update Rust crate tokio to 1.39.2 (#6249)" #6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
1 task
iliana
approved these changes
Aug 20, 2024
sunshowers
changed the title
|
In the control plane meeting today we decided to roll back Tokio 1.39 for r10, with the goal to land it early in r11. |
sunshowers
deleted the
sunshowers/spr/rfc-back-out-update-rust-crate-tokio-to-1392-6249
branch
sunshowers
added a commit
that referenced
this pull request
Aug 27, 2024
Tokio 1.39/mio 1.0 switches out the illumos impl to being eventfd based. For release 10 we decided that that was too risky, so we switched back to Tokio 1.38. Now that the r10 branch has been cut, we can go back and update Tokio to 1.39.3. We'd like to land this early in the cycle to get as much soak time as possible. See: * #6356 * #6249 * oxidecomputer/helios#169 * oxidecomputer/helios#171 * #6391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having second thoughts about upgrading Tokio so close to release 10, so I
want to suggest backing it out for now and landing it early in the release 11
cycle. Putting up this PR so we have a place to discuss this.
This backs out commit d7d4bea.