-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rust crate tokio to 1.39.2 #6249
Conversation
834f3da
to
c2c6f0a
Compare
I feel this one is 100% likely to fail, due to tokio 1.39+ issues on illumos. |
c2c6f0a
to
cc576a3
Compare
8ccb194
to
e6eee48
Compare
0302890
to
ed9d2db
Compare
ed9d2db
to
f6a6b39
Compare
A workaround for the illumos eventfd issue (tokio-rs/mio#1826) was landed by upstream and released as part of mio 1.0.2. We don't have as much confidence in eventfd as we do in the self-pipe-based impl, but we can't stay on an old Tokio version forever. However, I'm having second thoughts about getting this in so close to release 10. There's a case to be made for going back to 1.38 for now, and landing this update early in the r11 cycle. Putting up this draft PR for that: #6356 |
Tokio 1.39 updated its mio dependency to 1.0, which changed the waker impl on illumos from a self-pipe to eventfd. That has caused several issues already: * oxidecomputer/helios#169 * oxidecomputer/helios#171 Based on these and the potential for other lurking issues, we're making a policy decision to roll back to 1.38 (mio 0.8) for r10. We can't be off of the train forever so we're aiming to land the 1.39 update early in the r11 cycle. This backs out commit d7d4bea.
Tokio 1.39/mio 1.0 switches out the illumos impl to being eventfd based. For release 10 we decided that that was too risky, so we switched back to Tokio 1.38. Now that the r10 branch has been cut, we can go back and update Tokio to 1.39.3. We'd like to land this early in the cycle to get as much soak time as possible. See: * #6356 * #6249 * oxidecomputer/helios#169 * oxidecomputer/helios#171 * #6391
This PR contains the following updates:
1.38.1
->1.39.2
Release Notes
tokio-rs/tokio (tokio)
v1.39.2
: Tokio v1.39.2Compare Source
1.39.2 (July 27th, 2024)
This release fixes a regression where the
select!
macro stopped accepting expressions that make use of temporary lifetime extension. (#6722)v1.39.1
: Tokio v1.39.1Compare Source
1.39.1 (July 23rd, 2024)
This release reverts "time: avoid traversing entries in the time wheel twice" because it contains a bug. (#6715)
v1.39.0
: Tokio v1.39.0Compare Source
1.39.0 (July 23rd, 2024)
Added
AsyncSeek
forEmpty
(#6663)num_alive_tasks
(#6619, #6667)Command::as_std_mut
(#6608)watch::Sender::same_channel
(#6637){Receiver,UnboundedReceiver}::{sender_strong_count,sender_weak_count}
(#6661)Default
forwatch::Sender
(#6626)Clone
forAbortHandle
(#6621)consume_budget
(#6622)Changed
ReadBuf::put_slice()
(#6629)copy_bidirectional
andcopy
(#6532)num_cpus
withavailable_parallelism
(#6709)block_on
(#6692)IntoFuture
withtimeout
(#6666)IntoFuture
withjoin!
andselect!
(#6710)Fixed
Interval
(#6612)Added (unstable)
unhandled_panic
behavior for#[tokio::main]
and#[tokio::test]
(#6593)spawned_tasks_count
(#6114)worker_park_unpark_count
(#6696)Documented
tokio::io::stdout
documentation (#6674)join.rs
andtry_join.rs
(#6641)unhandled_panic
(#6660)JoinSet::try_join_next
when all tasks are running (#6671)Configuration
📅 Schedule: Branch creation - "after 8pm,before 6am" in timezone America/Los_Angeles, Automerge - "after 8pm,before 6am" in timezone America/Los_Angeles.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.