[xtask] move downloader to a separate binary #6171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
changed the title
sunshowers
changed the base branch from
sunshowers/spr/main.omicron-dev-move-downloader-to-a-separate-binary
to
main
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/omicron-dev-move-downloader-to-a-separate-binary
branch
jgallagher
added a commit
that referenced
this pull request
Aug 2, 2024
#6171 accidentally broke a4x2, because it needs to run `xtask download softnpu`, which used to directly download softnpu bits and now tries to `cargo run --bin xtask-downloader ...`. `cargo` isn't available within a4x2 VMs, so this change allows that environment to specify a path to the `xtask-downloader` binary directly. oxidecomputer/testbed#60 is the corresponding a4x2 PR to inject `xtask-downloader` and set the env var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While iterating on xtask I noticed that it could be pretty slow to compile.
Turned out that a lot of the dependencies were actually coming from the
download tool.
Move the downloader into a separate binary.
On Linux, this results in the number of build units for xtask dropping from 254
to 122. That's a pretty nice improvement.