Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a path to xtask-downloader via env var #6214

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

jgallagher
Copy link
Contributor

#6171 accidentally broke a4x2, because it needs to run xtask download softnpu, which used to directly download softnpu bits and now tries to cargo run --bin xtask-downloader .... cargo isn't available within a4x2 VMs, so this change allows that environment to specify a path to the xtask-downloader binary directly.

oxidecomputer/testbed#60 is the corresponding a4x2 PR to inject xtask-downloader and set the env var.

Copy link
Contributor

@sunshowers sunshowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@leftwo
Copy link
Contributor

leftwo commented Aug 2, 2024

Hmm. we may have to update the bench gimlet setup instruction too relating to this.

@jgallagher
Copy link
Contributor Author

Hmm. we may have to update the bench gimlet setup instruction too relating to this.

Is that https://github.com/oxidecomputer/omicron/blob/main/docs/how-to-run.adoc? At a glance it looks like bench gimlets still use cargo xtask ..., which should be fine, I think?

@jgallagher jgallagher merged commit 2d7f9d9 into main Aug 2, 2024
22 checks passed
@jgallagher jgallagher deleted the john/fix-a4x2 branch August 2, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants