Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sled-identifiers to instance vCPU stats #6128

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

bnaecker
Copy link
Collaborator

This adds the sled UUID and baseboard info into the existing vCPU stats. This is an incompatible change, and will require dropping old data from the previous versions of the timeseries. That's unused today, and it's not yet clear how we'll actually manage the timeseries data across a schema change, so I'd like to include this now.

This adds the sled UUID and baseboard info into the existing vCPU stats.
This is an incompatible change, and will require dropping old data from
the previous versions of the timeseries. That's unused today, and it's
not yet clear how we'll actually manage the timeseries data across a
schema change, so I'd like to include this now.
@bnaecker bnaecker requested a review from hawkw July 19, 2024 18:02
@bnaecker
Copy link
Collaborator Author

Here's a bit more context on the plan here. This adds some sled identifiers to the instance vCPU data, which is one piece of #5267. We don't yet have all the machinery in place for actually doing a timeseries upgrade, since I'm really just in the process of moving things to the TOML format that we'll used to describe those upgrades. But how we handle data across them is not yet clear.

In the meantime, I've also added the ability to drop individual timeseries by name in #6040. I'm planning to:

  • Make this upgrade here, which is incompatible
  • Update Propolis to use this new definition, populating the sled-identifiers in it using the interface I added in Add sled-agent endpoint for fetching sled identifiers #6086.
  • Pull that updated Propolis into Omicron, and at the same time include a ClickHouse schema upgrade which does nothing other than drop the original virtual_machine:* timeseries.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, I think.

@bnaecker
Copy link
Collaborator Author

Thanks for the gut-check @hawkw

@bnaecker bnaecker merged commit 1938877 into main Jul 19, 2024
22 checks passed
@bnaecker bnaecker deleted the add-sled-identifiers-to-vcpu-stats branch July 19, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants