Skip to content

Commit

Permalink
Add sled-identifiers to instance vCPU stats (#6128)
Browse files Browse the repository at this point in the history
This adds the sled UUID and baseboard info into the existing vCPU stats.
This is an incompatible change, and will require dropping old data from
the previous versions of the timeseries. That's unused today, and it's
not yet clear how we'll actually manage the timeseries data across a
schema change, so I'd like to include this now.
  • Loading branch information
bnaecker authored Jul 19, 2024
1 parent 92c39e5 commit 1938877
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion oximeter/oximeter/schema/virtual-machine.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name = "virtual_machine"
description = "A guest virtual machine instance"
authz_scope = "project"
versions = [
{ version = 1, fields = [ "instance_id", "project_id", "silo_id" ] },
{ version = 1, fields = [ "instance_id", "project_id", "silo_id", "sled_id", "sled_model", "sled_revision", "sled_serial" ] },
]

[[metrics]]
Expand Down Expand Up @@ -56,6 +56,22 @@ description = "ID of the virtual machine instance's project"
type = "uuid"
description = "ID of the virtual machine instance's silo"

[fields.sled_id]
type = "uuid"
description = "ID of the sled hosting the instance"

[fields.sled_model]
type = "string"
description = "Model number of the sled hosting the instance"

[fields.sled_revision]
type = "u32"
description = "Revision number of the sled hosting the instance"

[fields.sled_serial]
type = "string"
description = "Serial number of the sled hosting the instance"

[fields.state]
type = "string"
description = "The state of the vCPU"
Expand Down

0 comments on commit 1938877

Please sign in to comment.