Support deleting timeseries by name during schema upgrades #6040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for listing timeseries by name in a schema upgrade directory, and deleting all records (schema and data) from those timeseries during an offline ClickHouse database upgrade. The main goal here is a relatively simple but effective mechanism to clean up abandoned timeseries, while we figure out how to implement breaking changes more robustly. We alreay have examples of these abandonded timeseries in some existing installations. The existing effort to move timeseries to TOML also presents an opportunity to make one-time breaking changes for individual timeseries. Both of these can be supported with this mechanism. Fixes #5266
- Rename error variant for clarity - Comment on deletion batch size
zeeshanlakhani
approved these changes
Jul 11, 2024
ahl
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for listing timeseries by name in a schema upgrade directory, and deleting all records (schema and data) from those timeseries during an offline ClickHouse database upgrade. The main goal here is a relatively simple but effective mechanism to clean up abandoned timeseries, while we figure out how to implement breaking changes more robustly.
We alreay have examples of these abandonded timeseries in some existing installations. The existing effort to move timeseries to TOML also presents an opportunity to make one-time breaking changes for individual timeseries. Both of these can be supported with this mechanism.
Fixes #5266