Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DiskTest easier to use across multiple sleds #5939

Merged
merged 37 commits into from
Jul 2, 2024
Merged

Make DiskTest easier to use across multiple sleds #5939

merged 37 commits into from
Jul 2, 2024

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Jun 24, 2024

Builds on #5931

The DiskTest utility provides mechanisms to create zpools and datasets within a particular Sled Agent.
Historically, this was used on a single sled agent within the control plane test context, but more
recently, we've added a fair amount of multi-sled tests.

This PR updates the DiskTest to be more usable with multiple sleds:

  • It provides a DiskTestBuilder to help callers customize behavior
  • It lets callers access virtual disks spread across multiple distinct sleds

smklein added 25 commits June 20, 2024 12:36
@smklein
Start requiring zone filesystem argument
cee78bc
@smklein
Deprecate the old service format
3be4b6e
@smklein
Merge branch 'main' into nexus-zone-filesystems-2
8756076
@smklein
Merge branch 'deprecate-services-migration' into nexus-zone-filesyste…
0aac450 
…ms-2
@smklein
Plumbing through filesystem_pool, still need to make it optional
3833549
@smklein
Merge branch 'main' into deprecate-services-migration
aea4bdb
@smklein
review feedback
b58352f
@smklein
no bail just warn
a04e9c7
@smklein
Merge branch 'deprecate-services-migration' into nexus-zone-filesyste…
4615f1b 
…ms-2
@smklein
Merge branch 'main' into deprecate-services-migration
9f09c32
@smklein
Merge branch 'deprecate-services-migration' into nexus-zone-filesyste…
9db3042 
…ms-2
@smklein
optional value
a96fc81
@smklein
are we optional yet
9858dbf
@smklein
lie about filesystem_pools for simulated sled agent
f1e6f7a
@smklein
Patch test_builder_zones
8a9ade7
@smklein
Fix test_silos_external_dns_end_to_end
d7c462c
@smklein
patch v3 schema
3c59610
@smklein
Patch blueprint edit
1270098
@smklein
Add schema change
f48fba3
@smklein
fmt
684932d
@smklein
Merge branch 'main' into nexus-zone-filesystems-2
87b8df9
@smklein
helios tests
52406a6
@smklein
Make DiskTest easier to use across multiple sleds
713037e
@smklein
Merge branch 'main' into nexus-zone-filesystems-2
acaf91f
@smklein
Cleanup
b1339d4
@smklein smklein mentioned this pull request Jun 24, 2024
Merged
@smklein smklein marked this pull request as ready for review June 24, 2024 23:47
@smklein smklein requested a review from jmpesp June 24, 2024 23:47
jmpesp
jmpesp approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@jmpesp jmpesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few things, nothing blocking

nexus/test-utils/src/resource_helpers.rs Outdated Show resolved Hide resolved
nexus/tests/integration_tests/disks.rs Show resolved Hide resolved
nexus/tests/integration_tests/snapshots.rs Show resolved Hide resolved
Base automatically changed from nexus-zone-filesystems-2 to main July 1, 2024 23:26
@smklein smklein enabled auto-merge (squash) July 1, 2024 23:30
@smklein smklein merged commit 90a5d2f into main Jul 2, 2024
19 checks passed
@smklein smklein deleted the disk-test-cleanup branch July 2, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmpesp jmpesp jmpesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smklein @jmpesp