test environment could be more realistic #5239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to the environment that gets set up with a
ControlPlaneTestContext
in order to make it more realistic:OmicronZoneConfig
objects andPUT
them to the corresponding sled agent. The net result of this is that an inventory collected from the system comes much closer to reflecting what's actually present.The net result is that inventory collections are more like real systems and so the resulting internal DNS is also more like a real system. There's nothing in this PR that relies on that but there's a test in #5212 that does and that's how I tested this.