Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MGS available in nexus test suite #5780

Open
rcgoodfellow opened this issue May 15, 2024 · 3 comments
Open

Make MGS available in nexus test suite #5780

rcgoodfellow opened this issue May 15, 2024 · 3 comments

Comments

@rcgoodfellow
Copy link
Contributor

The test_port_settings_basic_crud test is currently disabled because it requires that nexus talk to MGS to figure out which switches it needs to talk to land port settings on a particular switch.

// TODO: unfortunately this test can no longer be run in the integration test
// suite because it depends on communicating with MGS which is not part
// of the infrastructure available in the integration test context.
#[ignore]
#[nexus_test]
async fn test_port_settings_basic_crud(ctx: &ControlPlaneTestContext) {

When this test was originally written, I believe we only had support for one switch and MGS was not involved in helping nexus make decisions. But now that we have multi-switch support, things are more complicated. This may ultimately not be necessary depending on how the following issues pan out e.g., if nexus determines what switches to talk to in ways that do not involve MGS.

@sunshowers
Copy link
Contributor

sunshowers commented May 15, 2024

I think for this and other related issues, we should effectively pin the version of mgd etc. We could either build it within omicron, or have a nextest setup script that can ensure that the right version of mgd (etc) is present on disk (and if not then download it). We should also consider enforcing consistency for non-test environments as well -- again, using either approach.

@davepacheco
Copy link
Collaborator

Is it MGD or MGS that we need to be available in the test suite? MGS has been available in the test suite for some time (since at least #5239).

@rcgoodfellow
Copy link
Contributor Author

This test was pulled in #4390, so we can likely retry this test now with the additional infrastructure from #5239 and #4291.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants