Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clickhouse] upload logs on test failure #4796

Merged
merged 7 commits into from
Jan 12, 2024
Merged

[clickhouse] upload logs on test failure #4796

merged 7 commits into from
Jan 12, 2024

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Jan 11, 2024 •
edited
Loading

Part of trying to figure out #4779 -- we now create ClickHouse logs in a
well-named directory which gets not-cleaned up (and therefore uploaded) at the end.

Tested this by introducing a failure in a test, and then seeing the following files in /tmp:

% find test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08 
test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08
test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08/log
test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08/clickhouse-server.log
test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08/clickhouse-server.errlog

Depends on oxidecomputer/dropshot#878.

@sunshowers
[𝘀𝗽𝗿] initial version
1c7de76 
Created using spr 1.3.5
@sunshowers
Copy link
Contributor Author

cc @bnaecker since you were discussing uploading ClickHouse logs

@sunshowers sunshowers mentioned this pull request Jan 11, 2024
Open
@sunshowers sunshowers marked this pull request as draft January 11, 2024 01:36
@sunshowers
Fix tests
cd21ca8 
Created using spr 1.3.5
@sunshowers
Rebase
24a8fd0 
Created using spr 1.3.5
@sunshowers
Rebase
ee66785 
Created using spr 1.3.5
@sunshowers
Rebase
1aed69c 
Created using spr 1.3.5
@sunshowers
Update dropshot
8fce394 
Created using spr 1.3.5
@sunshowers sunshowers changed the title [WIP] [clickhouse] upload logs on failure [clickhouse] upload logs on failure Jan 12, 2024
@sunshowers sunshowers changed the title [clickhouse] upload logs on failure [clickhouse] upload logs on test failure Jan 12, 2024
@sunshowers sunshowers marked this pull request as ready for review January 12, 2024 01:09
@sunshowers
Copy link
Contributor Author

I've been trying to repro the failures on this PR but sadly none of the runs have repro'd it so far. Hoping that landing this on main works.

smklein
smklein approved these changes Jan 12, 2024
View reviewed changes
test-utils/src/dev/clickhouse.rs Outdated Show resolved Hide resolved
@sunshowers
address review comment
477db9a 
Created using spr 1.3.5
@sunshowers sunshowers enabled auto-merge (squash) January 12, 2024 20:08
@sunshowers sunshowers merged commit 2ebbb7a into main Jan 12, 2024
20 of 21 checks passed
@sunshowers sunshowers deleted the sunshowers/spr/wip-clickhouse-upload-logs-on-failure branch January 12, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smklein smklein smklein approved these changes

@bnaecker bnaecker Awaiting requested review from bnaecker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunshowers @smklein