Skip to content

Commit

Permalink
[clickhouse] upload logs on test failure (#4796)
Browse files Browse the repository at this point in the history
Part of trying to figure out #4779 -- we now create ClickHouse logs in a
well-named directory which gets not-cleaned up (and therefore uploaded) at the end.

Tested this by introducing a failure in a test, and then seeing the following files in `/tmp`:

```
% find test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08 
test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08
test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08/log
test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08/clickhouse-server.log
test_all-c4d6fc05c1fc48de-test_local_users.3329283.1-clickhouse-I4Af08/clickhouse-server.errlog
```
  • Loading branch information
sunshowers authored Jan 12, 2024
1 parent 5f62bb8 commit 2ebbb7a
Show file tree
Hide file tree
Showing 10 changed files with 232 additions and 84 deletions.
2 changes: 1 addition & 1 deletion .github/buildomat/jobs/build-and-test-helios.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#: target = "helios-2.0"
#: rust_toolchain = "1.72.1"
#: output_rules = [
#: "/var/tmp/omicron_tmp/*",
#: "%/var/tmp/omicron_tmp/*",
#: "!/var/tmp/omicron_tmp/crdb-base*",
#: "!/var/tmp/omicron_tmp/rustc*",
#: ]
Expand Down
2 changes: 1 addition & 1 deletion .github/buildomat/jobs/build-and-test-linux.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#: target = "ubuntu-22.04"
#: rust_toolchain = "1.72.1"
#: output_rules = [
#: "/var/tmp/omicron_tmp/*",
#: "%/var/tmp/omicron_tmp/*",
#: "!/var/tmp/omicron_tmp/crdb-base*",
#: "!/var/tmp/omicron_tmp/rustc*",
#: ]
Expand Down
Loading

0 comments on commit 2ebbb7a

Please sign in to comment.