Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cargo.toml to match package-manifest for crucible #4597

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Update Cargo.toml to match package-manifest for crucible #4597

merged 2 commits into from
Dec 1, 2023

Conversation

leftwo
Copy link
Contributor

@leftwo leftwo commented Dec 1, 2023

No description provided.

@leftwo leftwo mentioned this pull request Dec 1, 2023
Closed
@bnaecker
Copy link
Collaborator

bnaecker commented Dec 1, 2023

The CI tests are failing, we think because this entrypoint and possibly others are using the older snake-case naming convention. These effectively duplicate the Crucible Pantry HTTP API, but in a separate place, making it tricky to keep things in sync.

Update propolis, simulated pantry
9cfdbcb 
Update propolis rev in Cargo.toml.
Update simulated pantry endpoints to match updated real pantry
@bnaecker bnaecker mentioned this pull request Dec 1, 2023
Open
@leftwo leftwo requested a review from bnaecker December 1, 2023 21:38
bnaecker
bnaecker approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down!

@bnaecker bnaecker mentioned this pull request Dec 1, 2023
Merged
@leftwo
Copy link
Contributor Author

leftwo commented Dec 1, 2023

In testing on a bench gimlet with these bits, I'm now able to upload an image using the CLI:

EVT22200005 # ${OXIDE} disk import --project alan --description "jammy disk" --path /alan/jammy-server-cloudimg-amd64.raw --disk jammysource
[00:12:21] [████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████] 2.20 GiB/2.20 GiB (3.04 MiB/s, 0s)done!
EVT22200005 #

@leftwo leftwo merged commit ac94fc0 into main Dec 1, 2023
22 checks passed
@leftwo leftwo deleted the alan/update-cargo-toml-crucible branch December 1, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnaecker bnaecker bnaecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leftwo @bnaecker