Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulated crucible pantry checks #4600

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

bnaecker
Copy link
Collaborator

@bnaecker bnaecker commented Dec 1, 2023

No description provided.

@bnaecker bnaecker requested review from ahl and leftwo December 1, 2023 21:36
@bnaecker
Copy link
Collaborator Author

bnaecker commented Dec 1, 2023

This is stacked on #4597 and fixes #4599 in the dumbest possible way. It downloads the expected Crucible API and ensures that the simulated one is a subset.

@bnaecker bnaecker force-pushed the add-simulated-crucible-pantry-checks branch 3 times, most recently from 2fa78d7 to dc244f3 Compare December 1, 2023 22:42
@leftwo leftwo self-requested a review December 1, 2023 22:52
@bnaecker bnaecker force-pushed the add-simulated-crucible-pantry-checks branch from dc244f3 to f6da308 Compare December 11, 2023 20:42
@bnaecker bnaecker enabled auto-merge (squash) December 11, 2023 20:42
@bnaecker bnaecker merged commit 23f149a into main Dec 11, 2023
21 of 22 checks passed
@bnaecker bnaecker deleted the add-simulated-crucible-pantry-checks branch December 11, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants