Update dropshot and openapiv3 deps #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmooney
force-pushed
the
openapi-update
branch
from
d8ca4dc to
ba992f3
Compare
The json specification generated by the updated openapiv3 is ordered slightly differently, but not in a way that matters to anything but "brute force" diff checks like expectorate. This updates the dependency and applies the reordering to the recorded OpenAPI specs.
pfmooney
force-pushed
the
openapi-update
branch
from
ba992f3 to
3364580
Compare
leftwo
approved these changes
Nov 13, 2023
|
|
||
| Usage: nexus <CONFIG_FILE_PATH> | ||
| Usage: nexus [OPTIONS] [CONFIG_FILE_PATH] |
There was a problem hiding this comment.
I think what is supported is:
nexus -i
or
nexus -o
or
nexus <config_file_path>
I don't know how to make Clap enforce that though, and what you have here essentially does the same
thing anyway.
There was a problem hiding this comment.
Frankly, I'd like to change nexus to operate like nexus run <cfg> or nexus openapi like all (?) of the other openapi servers in omicron. Updating this was a stop-gap so I could get it to emit openapi docs for me without having to rustle up a valid configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json specification generated by the updated openapiv3 is ordered slightly differently, but not in a way that matters to anything but "brute force" diff checks like expectorate. This updates the dependency and applies the reordering to the recorded OpenAPI specs.