Update propolis mock-server and client deps #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @leftwo, since this is tweaking how the crucible volume requests are constructed and passed through propolis-client |
pfmooney
force-pushed
the
propolis-client
branch
from
45b8675 to
c842328
Compare
|
On hold until it can be rebased atop #4488 to address the openapi-related test breakage. |
pfmooney
force-pushed
the
propolis-client
branch
from
c842328 to
a293692
Compare
|
Now that #4488 has landed, and this is rebased atop it, this should be ready for review. |
pfmooney
force-pushed
the
propolis-client
branch
from
a293692 to
64ffe41
Compare
leftwo
approved these changes
Nov 14, 2023
|
This is blocked on oxidecomputer/typify#440 (and the resulting chain through progenitor) to solve the |
With the propolis mock-server split out from the "real" propolis-server, and the handmade types cleaned out of the propolis-client library, we can now free ourselves of the somewhat circular dependency situation.
pfmooney
force-pushed
the
propolis-client
branch
from
64ffe41 to
59fe50b
Compare
|
Rebased, and bumped the typify dep to include that fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the propolis mock-server split out from the "real" propolis-server, and the handmade types cleaned out of the propolis-client library, we can now free ourselves of the somewhat circular dependency situation.