[wicket] add rack-update clear #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
Created using spr 1.3.5 [skip ci]
sunshowers
requested review from
jgallagher,
andrewjstone and
jordanhendricks
jgallagher
approved these changes
Nov 7, 2023
Created using spr 1.3.5 [skip ci]
sunshowers
changed the base branch from
sunshowers/spr/main.wicket-add-rack-update-clear
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to #4062, add a command to clear update state via the CLI.
To test this command, we make it have a
--message-formatoption which outputs JSON. This PR also adds support for reading that JSON, by movingClearUpdateStateResponseintowicket-common. Doing so meant thatSpIdentifierandSpTypealso moved intowicket-common. (We should maybe unify this with the gateway types, but that isn't necessary for this change.)Depends on #4450.
(Side note: I tried implementing
--message-format jsonforrack-update startandattachas well, but that's a somewhat bigger project with dubious upside so I shelved it for now. Implementingclearwas easy.)