[wicket] make CLI more usable in wicketd integration tests #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
Created using spr 1.3.5 [skip ci]
sunshowers
requested review from
jgallagher,
andrewjstone and
jordanhendricks
jgallagher
approved these changes
Nov 7, 2023
| /// Enables capturing of wicket's output. | ||
| pub enum OutputKind<'a> { | ||
| /// Captures output to the provided log, as well as a buffer. | ||
| Captured { |
There was a problem hiding this comment.
It doesn't look like this variant is ever constructed - is that coming in a subsequent PR?
Created using spr 1.3.5 [skip ci]
sunshowers
changed the base branch from
sunshowers/spr/main.wicket-make-cli-more-usable-in-wicketd-integration-tests
to
main
sunshowers
deleted the
sunshowers/spr/wicket-make-cli-more-usable-in-wicketd-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so that wicket's CLI is usable in wicketd's integration tests. To
achieve this, make a few changes:
execintoexec_with_args.exec_with_args, and makeexec_with_argsasync. This is so that wicketd'sintegration tests can run
exec_with_argswith a preexisting runtime.used by the
rack_updatecommands.Depends on #4062 (mostly because it is more convenient for me that way).