[test-utils] add log_prefix_for_test + store name of test in LogContext #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
Created using spr 1.3.5
sunshowers
changed the title
ahl
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
this looks good to me, but @davepacheco is more likely to have a useful opinion here than am I
davepacheco
approved these changes
Jan 11, 2024
|
Feel free to land when ready! |
sunshowers
deleted the
sunshowers/spr/test-utils-add-a-log_prefix_for_test-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to diagnose oxidecomputer/omicron#4779,
which only occurs in CI, I'm trying to collect ClickHouse logs. To do that we
need a way to uniquely identify the ClickHouse logs per test.
It is possible to derive the log prefix from
log_file_for_test, but it seemscleaner to do it this way.
Not entirely sure about this design though -- a
LogContextrepresents a single log file, but in this case we're also using it to generate a second path, kinda.