Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#39] Fix two sonar cloud issues #45

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions src/components/DicomControls.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,34 +4,6 @@
class="oc-background-brand oc-p-s oc-width-large oc-flex oc-flex-middle oc-flex-center oc-flex-around preview-controls-action-bar"
>
<!-- hide prev / next section while functionality is not yet implemented, set class of the wrapper div to 'oc-width-xlarge' once that section is activated -->
panagiotisbellias marked this conversation as resolved.
Show resolved Hide resolved
<!--
<div class="oc-flex oc-flex-middle">
<oc-button
v-oc-tooltip="previousDescription"
class="preview-controls-previous"
appearance="raw-inverse"
variation="brand"
:aria-label="previousDescription"
@click="$emit('togglePrevious')"
>
<oc-icon size="large" name="arrow-drop-left" variation="inherit" />
</oc-button>
<p v-if="!isFolderLoading" class="oc-m-rm preview-controls-action-count">
<span aria-hidden="true" v-text="ariaHiddenFileCount" />
<span class="oc-invisible-sr" v-text="screenreaderFileCount" />
</p>
<oc-button
v-oc-tooltip="nextDescription"
class="preview-controls-next"
appearance="raw-inverse"
variation="brand"
:aria-label="nextDescription"
@click="$emit('toggleNext')"
>
<oc-icon size="large" name="arrow-drop-right" variation="inherit" />
</oc-button>
</div>
-->
<div class="oc-flex oc-flex-middle">
<oc-button
v-oc-tooltip="imageShrinkDescription"
Expand Down
1 change: 1 addition & 0 deletions src/components/MetadataSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
</div>
<div v-if="isMetadataExtracted" id="dicom-metadata-sidebar-content" class="oc-p-s">
<table class="details-table">
<caption>Details table</caption>
panagiotisbellias marked this conversation as resolved.
Show resolved Hide resolved
<metadata-sidebar-table-row
v-bind="$props.patientInformation"
:metadata-section-name="'Patient Information'"
Expand Down