Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#39] Fix two sonar cloud issues #45

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[#39] Fix two sonar cloud issues #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66a2ce9
[#39] Fix two sonar cloud issues
panagiotisbellias Apr 10, 2024
100edcb
[#39] Fix reviewing points
panagiotisbellias Apr 11, 2024
3143445
[39] Fix drone build
panagiotisbellias Apr 11, 2024
a2895c0
[39] Fix drone build
panagiotisbellias Apr 11, 2024
4f6ea5a
[#39] Fix drone build
panagiotisbellias Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions src/components/DicomControls.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,35 +3,6 @@
<div
class="oc-background-brand oc-p-s oc-width-large oc-flex oc-flex-middle oc-flex-center oc-flex-around preview-controls-action-bar"
>
<!-- hide prev / next section while functionality is not yet implemented, set class of the wrapper div to 'oc-width-xlarge' once that section is activated -->
<!--
<div class="oc-flex oc-flex-middle">
<oc-button
v-oc-tooltip="previousDescription"
class="preview-controls-previous"
appearance="raw-inverse"
variation="brand"
:aria-label="previousDescription"
@click="$emit('togglePrevious')"
>
<oc-icon size="large" name="arrow-drop-left" variation="inherit" />
</oc-button>
<p v-if="!isFolderLoading" class="oc-m-rm preview-controls-action-count">
<span aria-hidden="true" v-text="ariaHiddenFileCount" />
<span class="oc-invisible-sr" v-text="screenreaderFileCount" />
</p>
<oc-button
v-oc-tooltip="nextDescription"
class="preview-controls-next"
appearance="raw-inverse"
variation="brand"
:aria-label="nextDescription"
@click="$emit('toggleNext')"
>
<oc-icon size="large" name="arrow-drop-right" variation="inherit" />
</oc-button>
</div>
-->
<div class="oc-flex oc-flex-middle">
<oc-button
v-oc-tooltip="imageShrinkDescription"
Expand Down
3 changes: 2 additions & 1 deletion src/components/MetadataSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
</oc-button>
</div>
<div v-if="isMetadataExtracted" id="dicom-metadata-sidebar-content" class="oc-p-s">
<table class="details-table">
<p id="mydesc">DICOM metadata details table</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is your reasoning for adding the id? where is it used?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is used in the table element

<table class="details-table" aria-describedby="mydesc">
<metadata-sidebar-table-row
v-bind="$props.patientInformation"
:metadata-section-name="'Patient Information'"
Expand Down