[#39] Fix two sonar cloud issues #45
Conversation
|
@panagiotisbellias can you please check why drone is failing after your changes and try to fix this? |
|
@koebel drone was failing due to eslint check so I added a description to the table in another way but it may be presented in the UI, if this is not intended I can remove it completely until another solution comes up |
| @@ -25,7 +25,8 @@ | |||
| </oc-button> | |||
| </div> | |||
| <div v-if="isMetadataExtracted" id="dicom-metadata-sidebar-content" class="oc-p-s"> | |||
| <table class="details-table"> | |||
| <p id="mydesc">DICOM metadata details table</p> | |||
There was a problem hiding this comment.
what is your reasoning for adding the id? where is it used?
There was a problem hiding this comment.
it is used in the table element
@panagiotisbellias can you please check yourself if the changes your suggesting affect the UI and if so, let me know who instructed you to make these UI changes? |
I'm sorry, but no instructions are provided to run the VueJS part. Please add instructions (e.g. in README) first otherwise leave this sonar cloud issue unsolved until new solution comes up Thanks, |
If you are interested in running this app, have a look at the documentation of ownCloud's web extension system at https://owncloud.dev/clients/web/extension-system/ Basically you need to have an instance of ocis web and the ocis backend running, then build and run the extension with and optionally then copy the config into the "external_apps" section of config of your ocis web instance (or create such a section if there isn't any) Hope that helps |
|
|
Description
Fix two sonar cloud issues removing commented out code and adding caption in a table html element
Related Issue
Motivation and Context
Reduces sonar cloud issues
Types of changes
Checklist: