Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 hide full screen button when not useful #4305

Merged
merged 1 commit into from
Dec 13, 2024
Merged

🐛 hide full screen button when not useful #4305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/@ourworldindata/grapher/src/core/Grapher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,9 +2419,10 @@ export class Grapher
}

@computed get hideFullScreenButton(): boolean {
const { windowInnerHeight } = this
if (!windowInnerHeight) return true
return this.windowInnerHeight! < this.frameBounds.height
// hide the full screen button if the full screen height
// is barely larger than the current chart height
const fullScreenHeight = this.windowInnerHeight!
return fullScreenHeight < this.frameBounds.height + 80
}

@computed private get availableWidth(): number {
Expand Down
Loading