Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 hide full screen button when not useful #4305

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Dec 13, 2024

This fixes a problem on mobile where showing/hiding the browser chrome (which happens on scroll) toggled the full screen button visibility, which lead to a jumpy layout.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@owidbot
Copy link
Contributor

owidbot commented Dec 13, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-hide-full-screen-button

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-12-13 17:48:48 UTC
Execution time: 1.22 seconds

@sophiamersmann sophiamersmann marked this pull request as ready for review December 13, 2024 17:54
@sophiamersmann sophiamersmann merged commit 5a48228 into master Dec 13, 2024
25 checks passed
@sophiamersmann sophiamersmann deleted the hide-full-screen-button branch December 13, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants