Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 cloudflare images DB setup #4274

Merged
merged 1 commit into from
Dec 10, 2024
+525 −0
Merged

🎉 cloudflare images DB setup #4274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions db/migration/1731360326761-CloudflareImages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { MigrationInterface, QueryRunner } from "typeorm"

export class CloudflareImages1731360326761 implements MigrationInterface {
public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`-- sql
ALTER TABLE images
ADD COLUMN cloudflareId CHAR(36) NULL,
ADD CONSTRAINT images_cloudflareId_unique UNIQUE (cloudflareId),
ADD COLUMN hash VARCHAR(255) NULL,
MODIFY COLUMN googleId VARCHAR(255) NULL,
MODIFY COLUMN defaultAlt VARCHAR(1600) NULL;`)
Comment on lines +9 to +11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just remembered there is this convention I like that I learned when using Django, where you don't allow char/text fields to be null, because then you have two ways to represent an empty value — empty string and null — and you usually don't want that.

We don't have to change it now, especially if you don't feel like you'd have enough time to test it. Otherwise, I think it would be good to do or just think about it in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's true, the billion dollar mistake and all. Maybe let's pen that in for a tech tea to see if we want to set a strong commitment to standardizing on this throughout the DB.


// One-way migration 👋
await queryRunner.query(`-- sql
UPDATE images
SET defaultAlt = NULL
WHERE defaultAlt = 'legacy-wordpress-upload';
`)
}

public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`-- sql
ALTER TABLE images
DROP COLUMN cloudflareId,
DROP COLUMN hash
`)

await queryRunner.query(`-- sql
UPDATE images
SET googleId = 'cloudflare_image'
WHERE googleId IS NULL
`)

await queryRunner.query(`-- sql
ALTER TABLE images
MODIFY COLUMN googleId VARCHAR(255) NOT NULL
`)
}
}
23 changes: 23 additions & 0 deletions db/migration/1732994843041-CloudflareImagesAddUserId.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { MigrationInterface, QueryRunner } from "typeorm"

export class CloudflareImagesAddUserId1732994843041
implements MigrationInterface
{
public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`-- sql
ALTER TABLE images
ADD COLUMN userId INTEGER,
ADD CONSTRAINT fk_user_images
FOREIGN KEY (userId) REFERENCES users(id)
ON DELETE SET NULL;
`)
}
public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(`-- sql
ALTER TABLE images DROP CONSTRAINT fk_user_images;
`)
await queryRunner.query(`-- sql
ALTER TABLE images DROP COLUMN userId;
`)
}
}
Loading
Loading