🎉 cloudflare images DB setup #4274
Conversation
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-12-10 16:58:58 UTC |
| ADD COLUMN hash VARCHAR(255) NULL, | ||
| MODIFY COLUMN googleId VARCHAR(255) NULL, | ||
| MODIFY COLUMN defaultAlt VARCHAR(1600) NULL;`) |
There was a problem hiding this comment.
I just remembered there is this convention I like that I learned when using Django, where you don't allow char/text fields to be null, because then you have two ways to represent an empty value — empty string and null — and you usually don't want that.
We don't have to change it now, especially if you don't feel like you'd have enough time to test it. Otherwise, I think it would be good to do or just think about it in the future.
There was a problem hiding this comment.
Yeah, that's true, the billion dollar mistake and all. Maybe let's pen that in for a tech tea to see if we want to set a strong commitment to standardizing on this throughout the DB.
| "Are you sure you want to delete ALL images from Cloudflare Images? (y/n) ", | ||
| (answer) => { | ||
| if (answer.toLowerCase() === "y") { | ||
| console.log("May God have mercy on your soul.") |
| } | ||
|
|
||
| await db.knexReadWriteTransaction(async (trx) => { | ||
| // await purgeRecords(trx) |
There was a problem hiding this comment.
Is this commented out on purpose?
Just the DB changes from #4214 so that we can merge this first, make sure the DB data is correct, and then merge the code changes