Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): fix chart type failures when y dimension is missing #4273

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Dec 10, 2024

I noticed that, in the admin, several chart types failed when creating a new chart and switching chart types before selecting a y variable: StackedArea and DataTable would just fail, with no way to recover from it.

image

image

@owidbot
Copy link
Contributor

owidbot commented Dec 10, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-chart-types-missing-var

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-12-10 11:39:40 UTC
Execution time: 1.38 seconds

@marcelgerber marcelgerber merged commit d47497f into master Dec 10, 2024
23 of 25 checks passed
@marcelgerber marcelgerber deleted the chart-types-missing-var branch December 10, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants