fix(admin): fix chart type failures when y dimension is missing (#4273)

owid · Dec 10, 2024 · d47497f · d47497f
1 parent 6fb21e8
commit d47497f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/packages/@ourworldindata/grapher/src/dataTable/DataTable.tsx b/packages/@ourworldindata/grapher/src/dataTable/DataTable.tsx
@@ -577,6 +577,8 @@ export class DataTable extends React.Component<{
 
     @computed private get tableCaption(): React.ReactElement | null {
         if (this.hasDimensionHeaders) return null
+        if (this.displayDimensions.length === 0) return null
+
         const singleDimension = this.displayDimensions[0]
         const titleFragments = (singleDimension.display.columnName
             .attributionShort ||

diff --git a/packages/@ourworldindata/grapher/src/stackedCharts/AbstractStackedChart.tsx b/packages/@ourworldindata/grapher/src/stackedCharts/AbstractStackedChart.tsx
@@ -286,6 +286,8 @@ export class AbstractStackedChart
 
     @computed
     private get entitiesAsSeries(): readonly StackedRawSeries<number>[] {
+        if (!this.yColumns.length) return []
+
         const { isProjection, owidRowsByEntityName } = this.yColumns[0]
         return this.selectionArray.selectedEntityNames
             .map((seriesName) => {