-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marcel's enhancements to server-side csv generation #4051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice, thanks a lot for these improvements!
bc1b6ff
to
e98a00d
Compare
a76f023
to
ae3cd6f
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @marcelgerber and the rest of your teammates on Graphite |
e98a00d
to
20a0eba
Compare
ae3cd6f
to
4b4c21d
Compare
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-10-10 12:38:42 UTC |
it's very lightweight, and uses the built-in `CompressionStream` for compression (available in CF Workers)
4b4c21d
to
6195555
Compare
Enhancements on top of #3613, see the commit messages for details.
The biggest change is replacing
jszip
withlittlezipper
, which (mostly) uses the browser-inbuilt (and Workers-inbuilt!)CompressionStream
API for zip generation, which gives us fast, native compression.It's also a good option if we ever should want to create a zip file directly in the browser - it uses
CompressionStream
if available ( = most modern browsers), or otherwise creates an uncompressed zip file as a fallback.