Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marcel's enhancements to server-side csv generation #4051

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Oct 10, 2024

Enhancements on top of #3613, see the commit messages for details.

The biggest change is replacing jszip with littlezipper, which (mostly) uses the browser-inbuilt (and Workers-inbuilt!) CompressionStream API for zip generation, which gives us fast, native compression.
It's also a good option if we ever should want to create a zip file directly in the browser - it uses CompressionStream if available ( = most modern browsers), or otherwise creates an uncompressed zip file as a fallback.

@marcelgerber marcelgerber changed the base branch from master to server-side-csv October 10, 2024 10:43
@marcelgerber marcelgerber requested a review from danyx23 October 10, 2024 10:43
@marcelgerber marcelgerber marked this pull request as ready for review October 10, 2024 10:44
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice, thanks a lot for these improvements!

@danyx23 danyx23 force-pushed the server-side-csv-marcel branch from ae3cd6f to 4b4c21d Compare October 10, 2024 12:12
@owidbot
Copy link
Contributor

owidbot commented Oct 10, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-server-side-csv-marcel

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-10-10 12:38:42 UTC
Execution time: 1.24 seconds

Copy link
Contributor

danyx23 commented Oct 10, 2024

Merge activity

  • Oct 10, 12:53 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 12:58 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 12:59 PM EDT: A user merged this pull request with Graphite.

@danyx23 danyx23 changed the base branch from server-side-csv to graphite-base/4051 October 10, 2024 16:53
@danyx23 danyx23 changed the base branch from graphite-base/4051 to master October 10, 2024 16:56
@danyx23 danyx23 force-pushed the server-side-csv-marcel branch from 4b4c21d to 6195555 Compare October 10, 2024 16:57
@danyx23 danyx23 merged commit e08b424 into master Oct 10, 2024
13 of 15 checks passed
@danyx23 danyx23 deleted the server-side-csv-marcel branch October 10, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants