garden: improvements to dev admin chart list #3798
Conversation
toni-sharpe
force-pushed
the
add-chartid-to-grapher
branch
from
310896f to
00a7e34
Compare
toni-sharpe
changed the title
toni-sharpe
force-pushed
the
add-chartid-to-grapher
branch
from
76dfd34 to
85aab55
Compare
toni-sharpe
changed the title
toni-sharpe
changed the title
* close the loop between seeing an issue and finding the chart in the embed interface
* made the chart graphic a bit wider so it's a bit easier to see the details, 100px was a bit small * to compensate, some width was taken off the name and ID
* in order to speed up the process of getting from issue to problem chart I made the chart ID into a direct link to the embed screen
* this rough POC just puts the chart and title together, as both benefit from a wider space, so it seems reasonable to stack them in one column
toni-sharpe
force-pushed
the
add-chartid-to-grapher
branch
from
85aab55 to
8122bee
Compare
|
@larsyencken tag OK I thought, I've been scarce, Not expecting anything else merged or started this month, doing a course (ML/neural networks). |
danyx23
added
the
external-contributor
|
@toni-sharpe thanks for experimenting with this! It looks nice but trades off higher rows with a nicer design and that means that fewer rows fit on screen. For us it's important to see many of these at once on a screen so we prefer the original design - but you can of course use your modifications on a local fork. Thanks again! |
|
@danyx23 fair enough, I can make, and/or share a bookmarklet or something, Commit |
|
Hi @toni-sharpe - I think changing the id to a link isn't particularily useful for us, no. |
|
No problem, I'll bookmark that embed link, then I'm fixed, I'll leave this screen as is unless an issue comes through |
Note no rush with this one, if it got as far as merge conflicts, I'd deal with them myself.
This improves things for me and therefore possibly also for folk who dev in the same way as me.
There was an issue, I think it has been edited, where "World" blocks the search and removing that word yielded the one needed chart.
But that has no link to the embed screen which is really useful, so I made the ID output in the table into a link that goes straight through to the embed screen. Having the side by side comparison with the live site is really useful, at least for me eg: this Marimekko labelling fix of mine a couple of months ago. In fact it provided the proof and screen-shots of it.
I also changed the widths a bit, made the chart a bit bigger because it's visual, and narrowed the name and ID columns.
(I'm working on a MacBook Air.)
Here's the overall result:
Final commit
I did this quick POC, it stacks the title and chart because both benefit from the wider space - easy to roll back