Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct link to embed screen/chartid output #3906

Closed
toni-sharpe opened this issue Aug 28, 2024 · 1 comment
Closed

Direct link to embed screen/chartid output #3906

toni-sharpe opened this issue Aug 28, 2024 · 1 comment

Comments

@toni-sharpe
Copy link
Contributor

Core problem

The embedded chart coparison screen is something I find really useful. ❤️

But currently it doesn't seem to have a link on the chart list

Proposed solution

Already exists, the PR was rejected - speculative improvements to the chart list and @danyx23 explained that they don't suit the team; however, in amongst that was this commit.

All it does is make the chart ID into a link to that screen.

Pretty simple so I'll just leave it at that, if the team feel this a good one, I can make a quick PR no problem.

Second commit

A second thing in there was this commit that adds the chartid to the output HTML 🌳 - this closes the loop a bit from seeing a chart live and actually finding it in admin.

Again the commit is really simple and atomic

Please respond with ❤️ for the link and 🌳 for the id in the output. Voting for both is cool. I can do both if there's interest.

Alternatively if someone just says "do it" then it will happen.

(I put too many things in that one, it was all bit exploratory and broke something important, however, I think both these have merit individually)

@danyx23
Copy link
Contributor

danyx23 commented Oct 1, 2024

Hey Toni! Thanks for this! These admin pages are primarily built for staff members and we don't really experience the issues that you describe here. For example, after logging in to the admin and registering as staff, a direct edit link is available to staff members in the share menu of a chart (i.e. it takes you to the admin).

As such we'll close this issue.

@danyx23 danyx23 closed this as completed Oct 1, 2024
@danyx23 danyx23 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants