💄 (grapher) remove isExplorable option #3323
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on |
sophiamersmann
force-pushed
the
grapher-remove-explorable
branch
from
e537b20 to
e38bbc5
Compare
There was a problem hiding this comment.
Nice one!
For reference, I'm pretty sure that this property was used for the circa-2019 old explorer work/prototype, and is therefore absolutely safe to remove at this point.
|
Ah, that's good to know! It's so cool that the link to the everything explorer is still working :)
|
sophiamersmann
force-pushed
the
grapher-remove-explorable
branch
from
e38bbc5 to
7f8480a
Compare
|
Ah, sadly the DB tests are still failing. Let's summon @danyx23! |
|
A wild Daniel appears! Ok this is one of these cases where, after you fix it, you really don't understand how this can ever have worked before. I don't get it. Whatever, the issue is fixed now! 🎉 ... 😬 |
|
haha, thanks a lot for looking into this! |
Warning
Db tests are failing.
Just a little bit of cleanup. Removes the
isExplorableproperty from Grapher's config and theisExplorablecolumn from thechartstable.The config schema states that the
isExplorableproperty is not in use and should be removed. I then noticed that thechartstable has a column calledisExplorablethat also isn't in use, so I decided to remove it too.Technically, this is a breaking schema change, but there is no real code change, so I guess it's okay not to increase the schema version etc.