🐛 commit svg tester diffs to different branches #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
sophiamersmann
changed the title
sophiamersmann
force-pushed
the
fix-svg-tester-actions
branch
from
c990249 to
8a05cdc
Compare
This was referenced Feb 19, 2024
sophiamersmann
force-pushed
the
fix-svg-tester-actions
branch
2 times, most recently
from
8b3e0f0 to
b545bec
Compare
sophiamersmann
force-pushed
the
fix-svg-tester-actions
branch
from
b545bec to
0eac3fd
Compare
danyx23
approved these changes
Feb 23, 2024
sophiamersmann
added a commit
that referenced
this pull request
Mar 1, 2024
> [!IMPORTANT] > Wait for #3211 to be merged. ### Current state - When exporting to static charts, we adjust the font size to fit the chart title into a single line if possible - The font size is decreased by not more than 20% using 0.5px steps - But we don't currently do this on the web ### Changes - We re-introduce this technique for charts rendered in an interactive environment (we had removed this for interactive charts in the redesign) - I think reducing the font size by 20% is quite a lot, so I opted for 15% instead (the old grapher also used 85% of the original font size as a threshold) - With 85%, the font size gets at most reduced to... - for narrow charts: 18px * 0.85 = 15.3px (subtitle font size = 12px) - for medium charts: 20px * 0.85 = 17px (subtitle font size = 13px) - for larger charts: 24px * 0.85 = 20.4px (subtitle font size = 14px) The SVG tester complains because we used to decrease by no more than 20% but now use 15%. Some charts look "worse" because of that, but these thresholds are arbitrary, and we have to draw the line somewhere...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
<my-branch>, then the first action now commits to a branch of the same name, and the other action commits to<my-branch>__all-viewsTests
The follow-up PR makes the SVG tester actions fail on purpose. Note that both actions commit to different branches:
SVG tester:
SVG tester (all views):