Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Playfair Semibold in static grapher exports #3225

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

samizdatco
Copy link
Contributor

The png-generation code in StaticRasterizer needs to preload any fonts it uses and had previously been expecting to use Playfair Medium for chart titles. The updated design involved changing the title weight to Semibold but neglected to update the rasterizer. This PR brings the rasterizer and static chart code in sync.

There are a number of pre-generated static exports that need to be re-rendered to use the updated typography. Since the baking process only generates a new export if the config has changed since the previous bake, we need to force a full re-render manually.

One possibility would be:

  1. hard-coding the chartIsSameVersion function in GrapherBaker.ts to return false
  2. triggering a bake
  3. restoring the normal lazy behavior of chartIsSameVersion

closes #3210
incorporates #2970

Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking this off my plate 🙏🏻

Good to merge once the the SVG tester actions (#3211) are fixed. I'm happy to take care of regenerating all SVGs once all changes to static charts have landed (including this one)

Copy link
Member

sophiamersmann commented Feb 23, 2024

@sophiamersmann sophiamersmann force-pushed the semibold-chart-titles branch 2 times, most recently from 859cd1a to f4fafc1 Compare February 28, 2024 14:51
@sophiamersmann sophiamersmann force-pushed the semibold-chart-titles branch from f4fafc1 to 6dfc074 Compare March 1, 2024 08:34
Copy link
Member

sophiamersmann commented Mar 1, 2024

Merge activity

@sophiamersmann sophiamersmann merged commit 9c4daeb into master Mar 1, 2024
18 of 26 checks passed
@sophiamersmann sophiamersmann deleted the semibold-chart-titles branch March 1, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use correct Semibold font weight in static chart titles
2 participants