refactor: bake redirects from db

[mlbrgl]

• refactor: bake redirects from db
• refactor: resolve internal redirects from db

Internal redirect resolver

The internal resolver is currently only used for prominent links. The following query reveals some examples of where it might be used:

select
    *
from
    posts_links pl
    join posts p on pl.sourceId = p.id
where
    pl.linkType = 'grapher'
    and componentType = 'prominent-link'
    and p.status = 'publish'
    and p.gdocSuccessorId is NULL
    and pl.target in (
        select
            slug
        from
            chart_slug_redirects csr
    )

For instance, in https://ourworldindata.org/ukraine-war

formatWpUrl refactor

This PR also simplifies the formatWpUrl function since none of the paths in redirects contain the "__" string:

SELECT url, action_data, action_code FROM wp_redirection_items WHERE (url like "%\_\_%" OR action_data like "%\_\_%")  and status = "enabled"

--> 0 results

[mlbrgl]

Current dependencies on/for this PR:

• master
  • PR feat(wp): add wp api snapshot migration #3165
    • PR Bake posts, pages and blocks from WP API snapshots #3166
      • PR feat: grapher page related research from DB content graph #3176
        • PR Merge content graph and chart references #3179
          • PR refactor: bake embeds from DB content graph #3182
            • PR Add redirects table and migration script #3185
              • PR refactor: bake redirects from db #3186 👈
                • PR feat: add about page template #3190
                  • PR refactor: pass knex as parameter #3194

This stack of pull requests is managed by Graphite.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[danyx23]

Looks good - if we take care of trailing slashes before we put them into the DB then we can simplify this a bit more even

[mlbrgl]

removed trailing slash processing after cleaning up redirects in a57bcca.

[mlbrgl]

Merge activity

• Feb 19, 12:38 PM EST: @mlbrgl started a stack merge that includes this pull request via Graphite.
• Feb 19, 12:38 PM EST: @mlbrgl merged this pull request with Graphite.