Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge content graph and chart references #3179

Merged
merged 6 commits into from
Feb 19, 2024
Merged

Conversation

mlbrgl
Copy link
Member

@mlbrgl mlbrgl commented Feb 7, 2024

This PR merges the content graph queries used in grapher pages (see #3176) and the references queries used in the chart admin to indicate where a chart is being used.

If fixes two issues on the tab page:

  • Overridden Wordpress posts now ignored
  • Remove duplicate posts

Reusable blocks are no longer surfaced. This is ok since reusable blocks are now dereferenced in the embedding article, which means a chart within a reusable block would show in the parent article. One exception is explorer content blocks, which are still standalone. A quick manual check on all explorers reveals that only one explorer references a chart: https://ourworldindata.org/explorers/plastic-pollution. Given these blocks' scope and limited lifetime, this caveat is acceptable.

A future PR should use these references during the check performed before deleting a chart. Currently, only gdocs are being checked.

Before

Screenshot 2024-02-07 at 17 07 50

After

Screenshot 2024-02-07 at 20 38 49

Testing links

Below are some testing links to grapher pages, backlinking to posts in different configurations.

Copy link

coderabbitai bot commented Feb 7, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@mlbrgl mlbrgl force-pushed the content-graph-references branch from dd38a3c to e5acb21 Compare February 7, 2024 19:23
@mlbrgl mlbrgl changed the title refactor(graph): get wordpress post references for charts from db Merge content graph and chart references Feb 7, 2024
@mlbrgl mlbrgl marked this pull request as ready for review February 7, 2024 19:59
@mlbrgl mlbrgl force-pushed the content-graph-references branch from e5acb21 to 12483b3 Compare February 13, 2024 08:41
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mlbrgl mlbrgl force-pushed the content-graph-references branch from 12483b3 to 97711f1 Compare February 13, 2024 20:37
@mlbrgl mlbrgl force-pushed the content-graph-references branch from 97711f1 to 4a1d045 Compare February 14, 2024 08:38
@mlbrgl mlbrgl force-pushed the content-graph-references branch from 4a1d045 to 1b7afea Compare February 18, 2024 08:59
@mlbrgl mlbrgl force-pushed the content-graph-references branch from 1b7afea to 53fb6dc Compare February 19, 2024 14:02
@mlbrgl mlbrgl force-pushed the content-graph-references branch from 53fb6dc to aceadfd Compare February 19, 2024 14:35
@mlbrgl
Copy link
Member Author

mlbrgl commented Feb 19, 2024

Merge activity

  • Feb 19, 12:02 PM EST: @mlbrgl started a stack merge that includes this pull request via Graphite.
  • Feb 19, 12:05 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 19, 12:06 PM EST: @mlbrgl merged this pull request with Graphite.

Base automatically changed from db-content-graph to master February 19, 2024 17:04
@mlbrgl mlbrgl force-pushed the content-graph-references branch from aceadfd to 8943401 Compare February 19, 2024 17:04
@mlbrgl mlbrgl merged commit 0158fd0 into master Feb 19, 2024
14 of 16 checks passed
@mlbrgl mlbrgl deleted the content-graph-references branch February 19, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants