-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge content graph and chart references #3179
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
dd38a3c
to
e5acb21
Compare
346822f
to
3b47356
Compare
e5acb21
to
12483b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
3b47356
to
8568bca
Compare
12483b3
to
97711f1
Compare
8568bca
to
445f734
Compare
97711f1
to
4a1d045
Compare
445f734
to
05ecc94
Compare
4a1d045
to
1b7afea
Compare
05ecc94
to
bbcf834
Compare
1b7afea
to
53fb6dc
Compare
bbcf834
to
3ba5145
Compare
53fb6dc
to
aceadfd
Compare
3ba5145
to
08fe279
Compare
aceadfd
to
8943401
Compare
This PR merges the content graph queries used in grapher pages (see #3176) and the references queries used in the chart admin to indicate where a chart is being used.
If fixes two issues on the tab page:
Reusable blocks are no longer surfaced. This is ok since reusable blocks are now dereferenced in the embedding article, which means a chart within a reusable block would show in the parent article. One exception is explorer content blocks, which are still standalone. A quick manual check on all explorers reveals that only one explorer references a chart: https://ourworldindata.org/explorers/plastic-pollution. Given these blocks' scope and limited lifetime, this caveat is acceptable.
A future PR should use these references during the check performed before deleting a chart. Currently, only gdocs are being checked.
Before
After
Testing links
Below are some testing links to grapher pages, backlinking to posts in different configurations.