-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 (gdocs) add key-indicator-collection component #3108
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
8936e11
to
30565b0
Compare
45b41c5
to
aec23fc
Compare
30565b0
to
0db0324
Compare
aec23fc
to
72307ca
Compare
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
d80513a
to
1950d00
Compare
ca05587
to
3aa2ce8
Compare
bb1cfe6
to
7976a4a
Compare
fa2c297
to
c5a98c4
Compare
54692df
to
8dc037c
Compare
fda504f
to
378a49f
Compare
27487e5
to
503f01c
Compare
afff1b5
to
b03f2bb
Compare
1cb21b7
to
1026548
Compare
31770ac
to
97a40fe
Compare
8bb07e9
to
49056a3
Compare
8a5f27d
to
11d8e0d
Compare
Yup, you merge into master and I'll rebase 🙂 |
0ea7b51
to
f7a1cb6
Compare
Adds a new GDoc component,
key-indicator-collection
, that renders multiple key indicator components with navigational UI around it.Example
Working example: Gdoc / Admin / Staging
Example with error states: Gdoc / Admin
Details
height: auto
can't be animated, so we have to keep track of the height of the contentmax-height
(instead ofheight
) doesn't work here because accordions are opened and closed at the same time; this would be out of sync if we usedmax-height
since the opening animation would start immediately while the closing animation would appear to be a little delayeduseHeight
tab
property. It's stored with the linked chart (note that we're doing this for all linked charts)