-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 (gdocs) add key-indicator component #3103
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
6d852c1
to
3d85ae3
Compare
49102dd
to
8936e11
Compare
30565b0
to
0db0324
Compare
WalkthroughThis update involves a significant overhaul aimed at integrating Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
1cb21b7
to
1026548
Compare
49056a3
to
5c3b96f
Compare
🎉 (gdocs) add key-indicator-collection component
Adds a new GDoc component,
key-indicator
, that showcases a given indicator by rendering an interactive Grapher chart, a title and motivational text, and some metadata.Note that the
key-indicator
component is used as a building block of a higher-order component,key-indicator-collection
(added in #3108), but can also be used as a stand-alone component.Examples
Working example: Gdoc / Admin / Staging
Example with error states: Gdoc / Admin
Spec
datapageUrl
(required)title
(required)blurb
(required): multi-paragraph motivational textsource
(optional): optional source overwriteMetadata defaults: the indicator title and source are inferred from metadata; both show the exact same string that is shown on a datapage (see screenshots below)
Datapage
Key indicator block
Technical details
linkedCharts
attachmentlinkedIndicators
that stores a subset of metadata for a given indicatorlinkedIndicators
that stores a subset of metadata propertiesGrapherBaker
and refactored it into a separate function (getVariableOfDatapageIfApplicable(grapher)
) that can be used elsewhereSummary by CodeRabbit